-
Notifications
You must be signed in to change notification settings - Fork 41
Updated custom scheme for flutter user #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated custom scheme for flutter user #486
Conversation
WalkthroughThe documentation for the Flutter SDK integration guide was updated to use a simpler custom URI scheme ( Changes
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/content/docs/developer-tools/sdks/native/flutter-sdk.mdx
(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: marcosmartini
PR: kinde-oss/documentation#226
File: src/content/docs/developer-tools/sdks/backend/nextjs-sdk.mdx:0-0
Timestamp: 2024-10-22T06:12:51.559Z
Learning: The Kinde documentation's base URL is not `kinde.com`, so links to the documentation should use the correct base URL.
Learnt from: marcosmartini
PR: kinde-oss/documentation#226
File: src/content/docs/developer-tools/sdks/backend/nextjs-sdk.mdx:0-0
Timestamp: 2024-10-22T06:13:23.808Z
Learning: In the Kinde documentation, links may use `localhost` URLs that are fixed to relative paths, and the docs base URL is not `kinde.com`.
src/content/docs/developer-tools/sdks/native/flutter-sdk.mdx (4)
Learnt from: marcosmartini
PR: kinde-oss/documentation#226
File: src/content/docs/developer-tools/sdks/backend/nextjs-sdk.mdx:0-0
Timestamp: 2024-10-22T06:12:51.559Z
Learning: The Kinde documentation's base URL is not `kinde.com`, so links to the documentation should use the correct base URL.
Learnt from: marcosmartini
PR: kinde-oss/documentation#226
File: src/content/docs/developer-tools/sdks/backend/nextjs-sdk.mdx:0-0
Timestamp: 2024-10-22T06:13:23.808Z
Learning: In the Kinde documentation, links may use `localhost` URLs that are fixed to relative paths, and the docs base URL is not `kinde.com`.
Learnt from: marcosmartini
PR: kinde-oss/documentation#253
File: src/content/docs/properties/work-with-properties/property-groups.mdx:13-13
Timestamp: 2024-11-12T06:00:08.396Z
Learning: In the project documentation, the `/kinde-apis/management` and `/kinde-apis/frontend` pages use a third-party API reference and client that loads a Single Page Application (SPA). Therefore, links to sections within these pages are valid, even if they appear to point to non-existent sections in static analysis, and should not be flagged.
Learnt from: DaveOrDead
PR: kinde-oss/documentation#364
File: src/content/docs/design/design-with-code/understand-page-design.mdx:42-42
Timestamp: 2025-03-19T03:59:26.373Z
Learning: The Kinde widget content properties use camelCase naming convention (e.g., `pageTitle` instead of `page_title`) in JSX code examples and documentation.
🔇 Additional comments (3)
src/content/docs/developer-tools/sdks/native/flutter-sdk.mdx (3)
86-88
: Confirm manifest placeholder is updated too.The example
.env
values now use the simplermyapp://
scheme.
Double-check that the GradleappAuthRedirectScheme
placeholder inbuild.gradle
is also updated tomyapp
so Android and the.env
stay in sync.
133-134
: Broken doc note/link and inconsistent scheme name
- The inline link text shows
myapp
but the URL still points athttp://com.kinde.app/
.- The explanatory sentence refers to
com.kinde.app
, conflicting with the newmyapp
example.-**Note:** `<your_custom_scheme>` has been defined previously as [`myapp`](http://com.kinde.app/) ... +**Note:** `<your_custom_scheme>` has been defined previously as [`myapp`](#) ...(or drop the link entirely).
[ suggest_nitpick ]
149-150
: LGTM – snippet matches.env
exampleThe Dart snippet now aligns with the updated
myapp://
scheme.
Description (required)
Login and registration redirects are not working on Android due to an incorrect custom scheme in Flutter, so I have updated the scheme to fix the issue.
Summary by CodeRabbit