fix: Post logout redirect URL

[DanielRivers]

Explain your changes

• When supplying a post logout redirect URL to the logout component, this was not consumed and continued to use the environment variable regardless.
• When a relative URL is supplied the site URL will be appended.

Checklist

• I have read the “Pull requests” section in the contributing guidelines.
• I agree to the terms within the code of conduct.

🛟 If you need help, consider asking for advice over in the Kinde community.

[coderabbitai]

Walkthrough

The recent changes to the logout functionality streamline the process of determining the post-logout redirect URL. By directly using the router client’s search parameters instead of relying on the session manager, the implementation reduces unnecessary complexity. This enhances clarity and efficiency by integrating the redirect logic into the logout process, resulting in a more straightforward flow for users.

Changes

Files	Change Summary
src/handlers/logout.js	Refactored logout function to directly obtain postLogoutRedirectURL from router client’s search parameters. Streamlined redirect URL handling by modifying authUrl without involving session management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant RouterClient
    participant AuthService

    User->>RouterClient: Initiate Logout
    RouterClient->>AuthService: Retrieve postLogoutRedirectURL
    alt URL is valid
        AuthService->>RouterClient: Redirect to specified URL
    else URL is invalid
        AuthService->>RouterClient: Redirect to default URL
    end

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7c62a2b and 7b4d36d.

Files selected for processing (1)

• src/handlers/logout.js (2 hunks)

Additional comments not posted (3)

src/handlers/logout.js (3)

1-2: Good practice: Explicit imports.

The import statements are clear and explicit, which is a good practice for maintainability.

---

13-13: Ensure the default redirect URL is configured.

The postLogoutRedirectURL is set to either the search parameter or a default value from the config. Ensure that config.postLogoutRedirectURL is properly configured to avoid potential issues.

---

18-18: LGTM! Ensure proper URL encoding.

The authUrl.searchParams.set method is used to set the redirect URL. Ensure that the URL is properly encoded to avoid any issues with special characters.