Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure always a single slash between domain and path in callbacks #71

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

DaveOrDead
Copy link
Member

Explain your changes

Commonly finding people have // between their domains and paths when deploying to services like Vercel that seem to add a trailing slash at build time.

Added a function to create callback URLs which ensures there is always a single slash between domain and path

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

Copy link
Collaborator

@marcosmartini marcosmartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosmartini marcosmartini merged commit 157de76 into main Oct 19, 2023
peterphanouvong pushed a commit that referenced this pull request Aug 19, 2024
Make sure always a single slash between domain and path in callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants