-
Notifications
You must be signed in to change notification settings - Fork 24
chore(deps): update dependency isort to v7 #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
BrandtKruger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #126 validation summary
Critical issue: Python version incompatibility
PR #126 upgrades isort from v5.12.0 to v7.0.0, which introduces a Python version requirement conflict.
Changes applied
Updated pyproject.toml: isort = "^5.12.0" → isort = "^7.0.0"
Note: requirements.txt still has isort>=5.12.0 (inconsistency)
Critical compatibility issue
Python version requirement conflict:
isort v7.0.0 requires Python 3.10+
SDK supports Python 3.9+ (as declared in pyproject.toml)
This upgrade breaks Python 3.9 CI/CD and developer workflows
Installation test:
isort v7.0.0 cannot be installed on Python 3.9.6
Error: "Requires-Python >=3.10.0"
CI/CD impact:
CI workflow tests Python 3.9, 3.10, 3.11, 3.12, 3.13
CI installs requirements.txt which includes isort
Python 3.9 test job will fail to install isort v7
This breaks the CI pipeline for Python 3.9
Developer impact:
Developers using Python 3.9 cannot install isort v7
This affects local development and formatting workflows
Important notes
isort is a development dependency:
Used for code formatting/linting
Not required by end users
Not used in SDK runtime code
Only affects developers and CI/CD
The upgrade breaks Python 3.9:
CI/CD will fail for Python 3.9 test jobs
Developers on Python 3.9 cannot use isort v7
This conflicts with SDK's Python 3.9+ support
Inconsistency:
pyproject.toml updated to ^7.0.0
requirements.txt still has isort>=5.12.0
This inconsistency needs to be resolved
Recommendations
Do not merge as-is — this breaks Python 3.9 CI/CD.
Options to fix:
Option A: Make isort conditional (recommended)
Keep isort v5.12.0 in requirements.txt for Python 3.9 compatibility
Use isort v7.0.0 only for Python 3.10+ environments
Update CI to conditionally install isort based on Python version
This maintains Python 3.9 support
Option B: Drop Python 3.9 support
Update pyproject.toml to require Python 3.10+
Update classifiers to remove Python 3.9
Update requirements.txt to isort>=7.0.0
This is a breaking change requiring a major version bump
Option C: Keep isort v5.12.0
Revert the upgrade
Keep isort v5.12.0 for Python 3.9 compatibility
Upgrade later when Python 3.9 support is dropped
Recommended approach:
Option A (conditional isort) is best because:
Maintains Python 3.9 support
Allows Python 3.10+ developers to use isort v7
Doesn't break CI/CD
No breaking changes for end users
Conclusion
PR #126 has a critical compatibility issue. The isort v7 upgrade breaks Python 3.9 support, which will cause CI/CD failures and prevent Python 3.9 developers from using the tooling.
The PR should not be merged until this issue is resolved. The recommended fix is to make isort conditional based on Python version (Option A), which maintains Python 3.9 support while allowing Python 3.10+ developers to use isort v7. Alternatively, if Python 3.9 support is being dropped, this should be done explicitly with a major version bump and proper documentation.
- Add conditional isort installation in [project.optional-dependencies] - Python 3.10+: isort >=7.0.0 - Python 3.9: isort >=5.12.0, <7.0 - Remove hardcoded isort from [tool.poetry.dev-dependencies] - Update requirements.txt with documentation comment - Maintains backwards compatibility with Python 3.9 while allowing Python 3.10+ users to use isort v7 Fixes Python 3.9 CI/CD compatibility issue with isort v7 upgrade. This PR builds on top of PR kinde-oss#126 (isort v7 upgrade) and adds Python 3.9 compatibility.
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
^5.12.0->^7.0.0Release Notes
PyCQA/isort (isort)
v7.0.0Compare Source
Changes
💥 Breaking Changes
🚀 Features
🪲 Fixes
3.14and fix any bugs (#2425) @DanielNoord👷 Continuous Integration
ruffinstead ofblack(#2432) @DanielNoordruff(#2431) @DanielNoord📦 Dependencies
v6.1.0Compare Source
v6.0.1Compare Source
v6.0.0Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.