-
Notifications
You must be signed in to change notification settings - Fork 24
Pr 140 #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pr 140 #145
Conversation
…>=7.10.6 - Update pytest-cov from >=4.1.0 to >=7.0.0 in requirements.txt to match pyproject.toml - Add coverage>=7.10.6 requirement (required by pytest-cov v7.0.0) - Add coverage to pyproject.toml dev-dependencies This ensures consistency between requirements.txt and pyproject.toml and satisfies pytest-cov v7.0.0's requirement for coverage >= 7.10.6.
WalkthroughUpdates to test coverage tooling: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
requirements.txt (1)
26-27: Consider version pinning strategy for coverage package.The
coverage>=7.10.6dependency uses a concrete lower bound without an upper bound (e.g.,coverage>=7.10.6,<8.0.0), which differs from other pinning strategies in the file. This could lead to compatibility issues if coverage v8 introduces breaking changes. Consider aligning the pinning strategy with existing patterns in the file.If you want to constrain to a major version like other dependencies, consider:
-coverage>=7.10.6 +coverage>=7.10.6,<8.0.0
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pyproject.tomlis excluded by!**/*.toml
📒 Files selected for processing (1)
requirements.txt(1 hunks)
Add patch = subprocess to .coveragerc [run] section to enable subprocess measurement for pytest-cov v7. pytest-cov v7 removed built-in subprocess measurement via .pth files, so it must be explicitly enabled. This configuration requires coverage>=7.10.6 (as specified in requirements.txt). If coverage is not yet upgraded, a warning may appear but will resolve once coverage is upgraded to the required version. Fixes critical issue identified in CodeRabbit review.
Explain your changes
This PR completes the pytest-cov v7 update from PR #140 by adding the missing dependency updates and ensuring consistency between
requirements.txtandpyproject.toml.Checklist
🛟 If you need help, consider asking for advice over in the Kinde community.