Skip to content

Conversation

@BrandtKruger
Copy link
Contributor

@BrandtKruger BrandtKruger commented Dec 2, 2025

Explain your changes

This PR completes the pytest-cov v7 update from PR #140 by adding the missing dependency updates and ensuring consistency between requirements.txt and pyproject.toml.

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

renovate bot and others added 2 commits November 25, 2025 17:05
…>=7.10.6

- Update pytest-cov from >=4.1.0 to >=7.0.0 in requirements.txt to match pyproject.toml
- Add coverage>=7.10.6 requirement (required by pytest-cov v7.0.0)
- Add coverage to pyproject.toml dev-dependencies

This ensures consistency between requirements.txt and pyproject.toml and
satisfies pytest-cov v7.0.0's requirement for coverage >= 7.10.6.
@BrandtKruger BrandtKruger requested a review from a team as a code owner December 2, 2025 16:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Walkthrough

Updates to test coverage tooling: requirements.txt now pins pytest-cov>=7.0.0 and adds coverage>=7.10.6; .coveragerc adds run: parallel = subprocess option for subprocess measurement compatible with coverage >=7.10.6.

Changes

Cohort / File(s) Summary
Dependency updates
requirements.txt
Replaced pytest-cov >=4.1.0 with pytest-cov >=7.0.0 and added coverage >=7.10.6 to the Development dependencies block.
Coverage configuration
.coveragerc
Added run: parallel = subprocess (with comment referencing coverage >=7.10.6) to enable subprocess collection for newer pytest-cov; no other config changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Pr 140' is vague and non-descriptive, using only a reference number without conveying the actual change. Revise the title to clearly describe the main change, such as 'Update pytest-cov to v7 and add subprocess measurement configuration'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly relates to the changeset by explaining the purpose of updating pytest-cov v7 dependencies and ensuring consistency between requirements.txt and pyproject.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
requirements.txt (1)

26-27: Consider version pinning strategy for coverage package.

The coverage>=7.10.6 dependency uses a concrete lower bound without an upper bound (e.g., coverage>=7.10.6,<8.0.0), which differs from other pinning strategies in the file. This could lead to compatibility issues if coverage v8 introduces breaking changes. Consider aligning the pinning strategy with existing patterns in the file.

If you want to constrain to a major version like other dependencies, consider:

-coverage>=7.10.6
+coverage>=7.10.6,<8.0.0
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7deb113 and 381041c.

⛔ Files ignored due to path filters (1)
  • pyproject.toml is excluded by !**/*.toml
📒 Files selected for processing (1)
  • requirements.txt (1 hunks)

Add patch = subprocess to .coveragerc [run] section to enable subprocess
measurement for pytest-cov v7. pytest-cov v7 removed built-in subprocess
measurement via .pth files, so it must be explicitly enabled.

This configuration requires coverage>=7.10.6 (as specified in requirements.txt).
If coverage is not yet upgraded, a warning may appear but will resolve once
coverage is upgraded to the required version.

Fixes critical issue identified in CodeRabbit review.
@BrandtKruger BrandtKruger requested a review from a team as a code owner January 17, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant