Add Dockerfile and Refactor Weather Alert Application: User Input for Dynamic Weather Alerts #85
Conversation
|
👋 @Amitabh-DevOps 👋 We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon. |
There was a problem hiding this comment.
Hi @Amitabh-DevOps,
Thank you for your valuable contribution. We already have the project available in this repository. If you would like to contribute to the same project, please create a directory within the existing Weather Alert directory. I recommend using the following structure: Weather Alert/your-usrName/project-files (excluding the project name, as that directory is already defined).
Thank you!
|
Yes i have done with changes which you have said , now review it
…On Fri, Oct 25, 2024 at 10:58 PM Aman Kumar ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi @Amitabh-DevOps <https://github.com/Amitabh-DevOps>,
Thank you for your valuable contribution. We already have the project
available in this repository. If you would like to contribute to the same
project, please create a directory within the existing Weather Alert
directory. I recommend using the following structure: Weather
Alert/your-usrName/project-files (excluding the project name, as that
directory is already defined).
Thank you!
—
Reply to this email directly, view it on GitHub
<#85 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKAIEHVFCZZZHQ4EZP7VBPLZ5J5SDAVCNFSM6AAAAABQS765RCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJVHE2TGMZXGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
If there is any changes you want to suggest it please go ahead i have did not modified the existing code , i just created a dir with my username as you have told |
|
I think it is so long time done , please check my PR |
Developer Checklist
Summary
This pull request introduces a Dockerfile for the weather alert application, streamlining the deployment process and ensuring consistent environments across different systems. Additionally, it refactors the application to include a user input form for city names, enabling dynamic weather alert checks based on user-defined locations. The application retrieves weather data in real-time, enhancing user engagement and usability.
However, the application is currently hosted on localhost, limiting its accessibility. Future work should focus on deploying the application to a cloud platform to allow users from various locations to access the service. Additionally, implementing AJAX could allow for real-time updates without requiring a page refresh, making the application more dynamic.
Suggestion: Consider developing this application using Django for better structure and scalability. I would be happy to assist in making improvements and implementing best practices in that framework.
Screenshot