Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] reranking base code #15

Merged
merged 2 commits into from
May 1, 2024
Merged

[FEAT] reranking base code #15

merged 2 commits into from
May 1, 2024

Conversation

kevinl424
Copy link
Collaborator

  • initial reranking base code
  • COLBERT reranking model
  • reorganized legacy routing agent source code

@kevinl424 kevinl424 linked an issue Apr 29, 2024 that may be closed by this pull request
Add reranking base code #14
Closed
seyeong-han
seyeong-han reviewed Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@seyeong-han seyeong-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add all these dev codes?
What about taking only essential parts, such as notebook files to prove our work.

@kevinl424
Copy link
Collaborator Author

Should we add all these dev codes? What about taking only essential parts, such as notebook files to prove our work.

Yep makes sense

seyeong-han
seyeong-han approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@seyeong-han seyeong-han left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this version. Great work!

@aishwarya-balaji aishwarya-balaji merged commit e143fbd into main May 1, 2024
@kevinl424 kevinl424 deleted the add-reranking branch May 8, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seyeong-han seyeong-han seyeong-han approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add reranking base code
3 participants
@kevinl424 @seyeong-han @aishwarya-balaji