-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI memary integration #29
Conversation
Requirement for PyPi Integration - setup.py
Additional edits to do before packaging: Update the folder structure to have it as memary/memary folder - can we just rename 'src' as memary? |
Requirement for PyPi - reviewers please suggest edits if needed
For PyPi integration - see setup.py
Uploaded to TestPyPI here: https://test.pypi.org/project/memary-test/. TODO before merging:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you guys test the codes first and upload them.
Thanks.
After running Following review
|
Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have told you earlier, but I think it's better to rename src
as memary
.
There is no problem with operating codes, but the structure looks redundant.
It depends on your preference. I'm fine with this structure also.
Was thinking under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kevinl424 @kingjulio8238 .
I tested PyPI build files and all good.
Also, I fixed the README image links to use the local diagrams
images.
Now, it is good to publish PyPI package after merging this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requirement for PyPi Integration - setup.py