This repository has been archived by the owner on May 6, 2020. It is now read-only.
aws,packet: make tags more uniform #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johananl
reviewed
Feb 13, 2020
docs/flatcar-linux/packet.md
Outdated
| @@ -316,6 +316,7 @@ Lokomotive implements support for some [DNS providers](../dns/), if your provide | |||
| | reservation_ids_default | Default hardware reservation ID for nodes not listed in the `reservation_ids` map. | "" | "next-available"| | |||
| | certs_validity_period_hours | Validity of all the certificates in hours | 8760 | 17520 | | |||
| | controller_clc_snippets [[1]](#clc-snippets-limitation) | Controller Container Linux Config snippets | [] | [example](../advanced/customization.md#usage) | | |||
| | tags | Optional details to tag on Packet resources | `[]` | `["CreatedBy-DevOpsTeam"]` | | |||
There was a problem hiding this comment.
I suggest we use : as a separator between the "key" and the "value" in Packet tags. The hyphen is less clear semantically IMO. Additionally, hyphens are much more likely to exist as part of either the key or the value, which would make it hard to know where the key ends and the value begins.
invidian
reviewed
Feb 13, 2020
docs/flatcar-linux/aws.md
Outdated
| @@ -223,7 +223,7 @@ Reference the DNS zone id with `"${aws_route53_zone.zone-for-clusters.zone_id}"` | |||
| | service_cidr | CIDR IPv4 range to assign to Kubernetes services | "10.3.0.0/16" | "10.3.0.0/24" | | |||
| | cluster_domain_suffix | FQDN suffix for Kubernetes services answered by coredns. | "cluster.local" | "k8s.example.com" | | |||
| | certs_validity_period_hours | Validity of all the certificates in hours | 8760 | 17520 | | |||
| | tags | Optional details to tag on AWS resources | `{}` | `{"CreatedBy" = "Devops team"}` | | |||
| | tags | Optional details to tag on AWS resources | `{}` | `{"CreatedBy" = "DevOps team"}` | | |||
There was a problem hiding this comment.
That seem unrelated to this PR/commit.
|
#170 has been merged, so this PR needs to be rebased. |
On Packet, tags are a list of strings. On AWS, tags are a key-value map. There are some default tags: - ManagedBy = Lokomotive - CreatedBy = Unspecified and some suggestions: - ManagedBy = Lokomotive - CreatedBy = DevOpsTeam
alban
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Packet, tags are a list of strings.
On AWS, tags are a key-value map.
There are some default tags:
and some suggestions:
Related: