-
Notifications
You must be signed in to change notification settings - Fork 24
Add instructions for minikube, kubectl-trace and IG #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few wording suggestions.
## Minikube requirements | ||
|
||
Please read [minikube.md](./minikube.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add one sentence before that: You'll need to have access to a working installation of minikube.
## Inspektor Gadget requirements | ||
|
||
Release [v0.2.0](https://github.com/kinvolk/inspektor-gadget/releases/tag/v0.2.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above, some sentence before this would be nice, although I'm not sure how to phrase it. Maybe, "This workshop uses release v0.2.0 for all examples" ?
## kubectl-trace requirements | ||
|
||
kubectl-trace branch [alban/ikheaders](https://github.com/kinvolk/kubectl-trace/tree/alban/ikheaders) with the following patches: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested pre-wording:
During this workshop we'll use a kubectl-trace with a few additional patches that aren't released yet. In particular, we'll use this ...
@@ -0,0 +1,46 @@ | |||
# Minikube | |||
|
|||
The Cloud Native BPF Workshop uses this branch of Minikube: [alban/bpf-workshop](https://github.com/kinvolk/minikube/tree/alban/bpf-workshop). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought your changes had been already merged in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change about CONFIG_IKHEADERS
for Inspektor Gadget was merged for v1.12.0-beta.1
but then unfortunately reverted for v1.12.0
. See kubernetes/minikube#8556 (comment)
And the change for CONFIG_FTRACE_SYSCALLS
for kubectl-trace is not merged in.
All your suggestions looks reasonable to me. Feel free to add them. |
No description provided.