Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Add instructions for minikube, kubectl-trace and IG #1

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Conversation

alban
Copy link
Member

@alban alban commented Jul 12, 2020

No description provided.

@alban alban requested a review from margamanterola July 12, 2020 14:23
Copy link
Contributor

@margamanterola margamanterola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few wording suggestions.

## Minikube requirements

Please read [minikube.md](./minikube.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add one sentence before that: You'll need to have access to a working installation of minikube.

## Inspektor Gadget requirements

Release [v0.2.0](https://github.com/kinvolk/inspektor-gadget/releases/tag/v0.2.0).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, some sentence before this would be nice, although I'm not sure how to phrase it. Maybe, "This workshop uses release v0.2.0 for all examples" ?

## kubectl-trace requirements

kubectl-trace branch [alban/ikheaders](https://github.com/kinvolk/kubectl-trace/tree/alban/ikheaders) with the following patches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested pre-wording:

During this workshop we'll use a kubectl-trace with a few additional patches that aren't released yet. In particular, we'll use this ...

@@ -0,0 +1,46 @@
# Minikube

The Cloud Native BPF Workshop uses this branch of Minikube: [alban/bpf-workshop](https://github.com/kinvolk/minikube/tree/alban/bpf-workshop).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought your changes had been already merged in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change about CONFIG_IKHEADERS for Inspektor Gadget was merged for v1.12.0-beta.1 but then unfortunately reverted for v1.12.0. See kubernetes/minikube#8556 (comment)

And the change for CONFIG_FTRACE_SYSCALLS for kubectl-trace is not merged in.

@alban alban merged commit 7a1af83 into master Jul 14, 2020
@alban
Copy link
Member Author

alban commented Jul 14, 2020

All your suggestions looks reasonable to me. Feel free to add them.

@alban alban deleted the alban/minikube branch August 12, 2020 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants