[TEST] SeccompProfile CRD: add new fields for seccomp notify #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rata
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
@alban awesome, thanks for doing this!
LGTM. Just a simple comment of a flag that must not be added (it is confusing, and there are already mistakes done in the OCI seccomp flags).
But that should be trivial, from my POV feel free to fix that and just open the PR upstream
| @@ -64,7 +68,7 @@ type SeccompProfileSpec struct { | |||
| // +kubebuilder:validation:Enum=SCMP_ARCH_NATIVE;SCMP_ARCH_X86;SCMP_ARCH_X86_64;SCMP_ARCH_X32;SCMP_ARCH_ARM;SCMP_ARCH_AARCH64;SCMP_ARCH_MIPS;SCMP_ARCH_MIPS64;SCMP_ARCH_MIPS64N32;SCMP_ARCH_MIPSEL;SCMP_ARCH_MIPSEL64;SCMP_ARCH_MIPSEL64N32;SCMP_ARCH_PPC;SCMP_ARCH_PPC64;SCMP_ARCH_PPC64LE;SCMP_ARCH_S390;SCMP_ARCH_S390X;SCMP_ARCH_PARISC;SCMP_ARCH_PARISC64;SCMP_ARCH_RISCV64 | |||
| type Arch string | |||
|
|
|||
| // +kubebuilder:validation:Enum=SECCOMP_FILTER_FLAG_TSYNC;SECCOMP_FILTER_FLAG_LOG;SECCOMP_FILTER_FLAG_SPEC_ALLOW | |||
| // +kubebuilder:validation:Enum=SECCOMP_FILTER_FLAG_TSYNC;SECCOMP_FILTER_FLAG_LOG;SECCOMP_FILTER_FLAG_SPEC_ALLOW;SECCOMP_FILTER_FLAG_NEW_LISTENER | |||
There was a problem hiding this comment.
This shouldn't be added. See this PR: opencontainers/runtime-spec#1096
deploy/base/crds/seccompprofile.yaml
Outdated
| @@ -97,8 +98,16 @@ spec: | |||
| - SECCOMP_FILTER_FLAG_TSYNC | |||
| - SECCOMP_FILTER_FLAG_LOG | |||
| - SECCOMP_FILTER_FLAG_SPEC_ALLOW | |||
| - SECCOMP_FILTER_FLAG_NEW_LISTENER | |||
deploy/namespace-operator.yaml
Outdated
| @@ -308,8 +309,16 @@ spec: | |||
| - SECCOMP_FILTER_FLAG_TSYNC | |||
| - SECCOMP_FILTER_FLAG_LOG | |||
| - SECCOMP_FILTER_FLAG_SPEC_ALLOW | |||
| - SECCOMP_FILTER_FLAG_NEW_LISTENER | |||
deploy/openshift-dev.yaml
Outdated
| @@ -308,8 +309,16 @@ spec: | |||
| - SECCOMP_FILTER_FLAG_TSYNC | |||
| - SECCOMP_FILTER_FLAG_LOG | |||
| - SECCOMP_FILTER_FLAG_SPEC_ALLOW | |||
| - SECCOMP_FILTER_FLAG_NEW_LISTENER | |||
deploy/openshift.yaml
Outdated
| @@ -308,8 +309,16 @@ spec: | |||
| - SECCOMP_FILTER_FLAG_TSYNC | |||
| - SECCOMP_FILTER_FLAG_LOG | |||
| - SECCOMP_FILTER_FLAG_SPEC_ALLOW | |||
| - SECCOMP_FILTER_FLAG_NEW_LISTENER | |||
deploy/operator.yaml
Outdated
| @@ -308,8 +309,16 @@ spec: | |||
| - SECCOMP_FILTER_FLAG_TSYNC | |||
| - SECCOMP_FILTER_FLAG_LOG | |||
| - SECCOMP_FILTER_FLAG_SPEC_ALLOW | |||
| - SECCOMP_FILTER_FLAG_NEW_LISTENER | |||
alban
force-pushed
the
alban_notify
branch
2 times, most recently
from
b27da39
to
294bb86
Compare
Seccomp notify is a new feature in container runtimes introduced by - https://github.com/opencontainers/runtime-spec PR 1074 - https://github.com/opencontainers/runc PR 2682 (available in runc 1.1.0) This patch adds: - The new seccomp action SCMP_ACT_NOTIFY to defer the decision to a seccomp agent - The ListenerPath and ListenerMetadata fields so the runtime can contact the seccomp agent. Note that the flag SECCOMP_FILTER_FLAG_NEW_LISTENER is not added. See https://github.com/opencontainers/runtime-spec PR 1096 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seccomp notify is a new feature in container runtimes introduced by
This patch adds:
seccomp agent
contact the seccomp agent.
Note that the flag SECCOMP_FILTER_FLAG_NEW_LISTENER is not added. See
https://github.com/opencontainers/runtime-spec PR 1096 for details.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR have test?
Special notes for your reviewer:
Does this PR introduce a user-facing change?