Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/basic card deck operations #27

Merged
merged 14 commits into from
May 19, 2023
Merged

Feature/basic card deck operations #27

merged 14 commits into from
May 19, 2023

Conversation

4KevR
Copy link
Contributor

@4KevR 4KevR commented May 11, 2023

This PR implements:

  • integration of jwt auth into api operations
  • public id concept for groups, decks and cards
  • created card deck & collaboration service
  • migrated login & register service to user service
  • api routes
    • get all groups from a user
    • get all decks from a group
    • get all cards from a deck
    • create new deck in a group
    • create new card in a deck
  • added pgadmin to docker-compose
  • new store concept

@4KevR 4KevR added the enhancement New feature or request label May 11, 2023
@4KevR 4KevR self-assigned this May 11, 2023
@memeToasty memeToasty force-pushed the feature/basic-card-deck-operations branch from 327c3c8 to e7f0182 Compare May 12, 2023 07:12
darmiel
darmiel reviewed May 12, 2023
View reviewed changes
backend/pkg/helper/publicID.go Outdated Show resolved Hide resolved
backend/pkg/model/card.go Outdated Show resolved Hide resolved
backend/pkg/model/deck.go Outdated Show resolved Hide resolved
backend/pkg/model/group.go Outdated Show resolved Hide resolved
backend/services/carddeck/handler/carddeck.go Outdated Show resolved Hide resolved
backend/store/postgres.go Show resolved Hide resolved
backend/store/postgres.go Outdated Show resolved Hide resolved
backend/store/postgres.go Outdated Show resolved Hide resolved
backend/store/postgres.go Outdated Show resolved Hide resolved
backend/pkg/helper/jwtHelper.go Outdated Show resolved Hide resolved
darmiel
darmiel reviewed May 13, 2023
View reviewed changes
backend/pkg/helper/publicID.go Outdated Show resolved Hide resolved
backend/pkg/model/card.go Outdated Show resolved Hide resolved
backend/pkg/model/group.go Outdated Show resolved Hide resolved
@4KevR 4KevR force-pushed the feature/basic-card-deck-operations branch from b8caf6f to 3b7aaac Compare May 16, 2023 09:19
TomRomeo
TomRomeo requested changes May 16, 2023
View reviewed changes
Copy link
Contributor

@TomRomeo TomRomeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just found some possible errors / missing permission checks. Apart from that, we should come together as a group and discuss the implementation of a PublicID. Maybe we can find a better solution, since it seems like a duplication of the ID field at the current time.

backend/pkg/helper/jwtHelper.go Outdated Show resolved Hide resolved
backend/services/carddeck/handler/carddeck.go Outdated Show resolved Hide resolved
backend/services/collaboration/handler/collaboration.go Show resolved Hide resolved
backend/services/carddeck/handler/carddeck.go Show resolved Hide resolved
backend/services/carddeck/handler/carddeck.go Show resolved Hide resolved
backend/pkg/helper/publicID.go Outdated Show resolved Hide resolved
darmiel
darmiel reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@darmiel darmiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with the review, looks good 👍

backend/pkg/helper/publicID.go Outdated Show resolved Hide resolved
backend/services/carddeck/main.go Show resolved Hide resolved
backend/store/postgres.go Outdated Show resolved Hide resolved
darmiel
darmiel reviewed May 17, 2023
View reviewed changes
Copy link
Contributor

@darmiel darmiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nits

backend/services/carddeck/handler/carddeck.go Outdated Show resolved Hide resolved
backend/services/carddeck/handler/carddeck.go Outdated Show resolved Hide resolved
memeToasty
memeToasty approved these changes May 17, 2023
View reviewed changes
backend/pkg/helper/jwtHelper.go Show resolved Hide resolved
TomRomeo
TomRomeo approved these changes May 19, 2023
View reviewed changes
backend/pkg/helper/publicID.go Outdated Show resolved Hide resolved
backend/pkg/helper/publicID.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@4KevR 4KevR merged commit 02fadb1 into main May 19, 2023
@4KevR 4KevR deleted the feature/basic-card-deck-operations branch May 19, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darmiel darmiel darmiel left review comments

@memeToasty memeToasty memeToasty approved these changes

@Julian702 Julian702 Julian702 approved these changes

@TomRomeo TomRomeo TomRomeo approved these changes

Assignees

@4KevR 4KevR

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@4KevR @memeToasty @TomRomeo @Julian702 @darmiel @tobschli