Add comment to RANGES #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiorky
reviewed
Oct 30, 2024
src/croniter/croniter.py
Outdated
| @@ -186,6 +186,9 @@ class CroniterNotAlphaError(CroniterBadCronError): | |||
|
|
|||
| class croniter(object): | |||
| MONTHS_IN_YEAR = 12 | |||
|
|
|||
| # This helps with expanding `*` fields into `lower-upper` ranges. Each item | |||
| # in this tuple maps to the field index of YEAR_FIELDS. | |||
There was a problem hiding this comment.
comment partially wrong, s/ field index of YEAR_FIELDS/corresponding field index/ would be more appropriate as it is used by any form of cron no matter unix, second, or year one.
There was a problem hiding this comment.
Yeah makes sense. My intention was to say that it includes everything up to the YEAR_FIELDS, but this is probably a bit less confusing.
Updated
Open
kiorky
force-pushed
the
master
branch
3 times, most recently
from
06366ef to
fcf5ff8
Compare
evanpurkhiser
force-pushed
the
range-comment
branch
from
9fe24ad to
9e07578
Compare
|
Thx again again again again again again again again again for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.