Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/38 circles #39

Merged
merged 16 commits into from
Jan 10, 2022
Merged

Feat/38 circles #39

merged 16 commits into from
Jan 10, 2022

Conversation

triszt4n
Copy link
Member

@triszt4n triszt4n commented Dec 27, 2021 •
edited
Loading

Closes #38

After merging this PR, when redeploying to lois, first we need to migrate, then we need to create the Kir-Dev Circle entity and then connect all the existing albums to this Circle entity, and then create Membership entities (with Kir-Dev Circle entity) for all the Users already in the database.

News:

  • new workflow after logging in: joining a circle, then wait for the circle admin to accept the membership request, and then you can create albums.
  • Albums might not be created without circle, but if you do not belong to any circle, you cannot at all create albums.
  • Site admin has all of the privileges, circle admin has management privileges for their circle.

Extra:

  • Circle can be created with a logo

@triszt4n triszt4n marked this pull request as ready for review December 27, 2021 22:28
SepsiLaszlo
SepsiLaszlo requested changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@SepsiLaszlo SepsiLaszlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great feature! 🎉
I left some thing to consider. 🔍

app/views/circles/index.html.erb Show resolved Hide resolved
app/models/circle.rb Outdated Show resolved Hide resolved
app/controllers/application_controller.rb Show resolved Hide resolved
app/controllers/application_controller.rb Outdated Show resolved Hide resolved
app/controllers/application_controller.rb Outdated Show resolved Hide resolved
app/views/albums/_form.html.erb Outdated Show resolved Hide resolved
app/views/albums/_form.html.erb Outdated Show resolved Hide resolved
app/views/albums/show.html.erb Outdated Show resolved Hide resolved
@triszt4n triszt4n requested a review from SepsiLaszlo January 9, 2022 17:33
SepsiLaszlo
SepsiLaszlo approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@SepsiLaszlo SepsiLaszlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱 Really good work!

bbucsy
bbucsy approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@bbucsy bbucsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Maybe with the circle and admin authorization, we could wire the pundit gem here, to permissions more frendly to read. But that would be a future PR.

@triszt4n triszt4n mentioned this pull request Jan 10, 2022
Closed
@triszt4n triszt4n merged commit 9a713b4 into master Jan 10, 2022
@triszt4n triszt4n deleted the feat/38-circles branch January 10, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SepsiLaszlo SepsiLaszlo SepsiLaszlo approved these changes

@bbucsy bbucsy bbucsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New entity: Circle
4 participants
@triszt4n @bbucsy @SepsiLaszlo @lint-action