Skip to content

Commit

Permalink
Alert: Use primary color instead of success color for ok button (#3623)
Browse files Browse the repository at this point in the history
  • Loading branch information
RasmusKjeldgaard authored Sep 23, 2024
1 parent d4682b1 commit b4304aa
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
5 changes: 0 additions & 5 deletions libs/designsystem/button/src/button.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,6 @@ $button-margin: utils.size('xxxs');
margin-inline-start: utils.size('s');
}

:host-context(kirby-alert).ok-btn {
--kirby-button-background-color: #{utils.get-color('success')};
--kirby-button-color: #{utils.get-color('success-contrast')};
}

:host-context(kirby-dropdown) {
// place arrow-icon in dropdown correctly
justify-content: space-between;
Expand Down
12 changes: 1 addition & 11 deletions libs/designsystem/modal/src/modal/alert/alert.component.spec.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import { createHostFactory, SpectatorHost } from '@ngneat/spectator';

import { DesignTokenHelper } from '@kirbydesign/designsystem/helpers';

import { IconModule } from '@kirbydesign/designsystem/icon';

import { AlertComponent } from './alert.component';
const getColor = DesignTokenHelper.getColor;

describe('AlertComponent', () => {
let spectator: SpectatorHost<AlertComponent>;
Expand Down Expand Up @@ -59,13 +56,6 @@ describe('AlertComponent', () => {
expect(okButton).toHaveClass('lg');
});

it('should have success colors on button', () => {
expect(okButton).toHaveComputedStyle({
'background-color': getColor('success'),
color: getColor('success', 'contrast'),
});
});

it('should have default size when cancel button', () => {
expect(okButton.attributes['ng-reflect-size']).toBeUndefined();
});
Expand Down

0 comments on commit b4304aa

Please sign in to comment.