Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Use popover #2087

Open
4 of 6 tasks
alxzak opened this issue Mar 7, 2022 · 0 comments
Open
4 of 6 tasks

[ENHANCEMENT]: Use popover #2087

alxzak opened this issue Mar 7, 2022 · 0 comments

Comments

@alxzak
Copy link
Collaborator

alxzak commented Mar 7, 2022

Where are we now?

With #1671 the input property usePopover was introduced to the dropdown. When this is enabled the PopoverComponent is used to position the pop-out box.

This was done in order to be able to solve the bugs mentioned in the description of the aforementioned PR.

usePopover is set to false by default as we're not certain if it will introduce any bugs. Per 14. March 2022, testing has begun where some consumers of Kirby try to set usePopover="true" for their dropdowns.

What's next?

The goal is to eventually have usePopover="true" be the default. To do this we must:

  1. Solve any reported bugs from consumer projects testing the popover functionality (if any).
  2. Decide in which major version we will make it default. As soon as we know, we should implement a deprecation warning, letting people know that the default value will be change.
  3. In the decided major remove the usePopover input property and just use the functionality per default.

Issues popover will allow us to solve:

Related issues:

Other:

@alxzak alxzak added this to the M12 ( 7/4 - 15/6) milestone Mar 7, 2022
@RasmusKjeldgaard RasmusKjeldgaard removed this from the M12 ( 7/4 - 15/6) milestone Apr 28, 2022
@RasmusKjeldgaard RasmusKjeldgaard changed the title [TRACKING] Use popover [ENHANCEMENT]: Use popover Feb 5, 2024
@Fuzzy3 Fuzzy3 moved this to ⏰ Not Prioritized in Kirby Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📙 Backlog
Development

No branches or pull requests

2 participants