Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOCKED][Enhancement] Responsive Actionsheet (On large screens) #404

Closed
4 tasks
Tracked by #2087
bommariusser opened this issue Jul 3, 2019 · 5 comments
Closed
4 tasks
Tracked by #2087
Assignees
Labels
component:Action Sheet enhancement New feature or request priority 1 Tablet Tablet support related issues

Comments

@bommariusser
Copy link
Contributor

bommariusser commented Jul 3, 2019

Is your enhancement request related to a problem? Please describe.
The actionsheet looks the same on small and big screens, but thats not intended.

we want the actionsheet to be visually different on big screens.

See example in browser: https://cookbook.kirby.design/examples/page/custom-title
See also screenshot below

Skærmbillede 2020-01-31 kl  08 33 15

TODO:

@labanos
Copy link
Contributor

labanos commented Jul 11, 2019

"parked" til after 1st release for now - might change if web is prioritized differently.

@labanos labanos added this to the After 1st release milestone Jul 11, 2019
@bommariusser
Copy link
Contributor Author

sure @labanos lad os tage det mandag :) det er nok mere >720 og ikke bare kun web :)

@bommariusser bommariusser changed the title [Enhancement] Visual update & scaling support [Enhancement] Scaling support Jul 17, 2019
@bommariusser bommariusser changed the title [Enhancement] Scaling support [Enhancement] Responsive (On large screens) Jan 8, 2020
@bommariusser bommariusser added the Tablet Tablet support related issues label Jun 15, 2020
@bommariusser bommariusser changed the title [Enhancement] Responsive (On large screens) [Enhancement] Responsive Actionsheet (On large screens) Jul 13, 2020
@jakobe
Copy link
Collaborator

jakobe commented Feb 23, 2021

Tech refinement:

  • There should be a way to semantically place the action sheet below a button, i.e. a combination of button + action sheet:
<button kirby-button>
   <kirby-icon name="more"></kirby-icon>
   <kirby-action-sheet>[options...]</kirby-action-sheet>
</button>

This would make it possible to style the "popout" i.e. the card in a similar way we do it on the dropdown (absolute positioned with z-index, but without left-right-top-bottom, so it renders below the button)

The above should be wrapped in a kirby-action-sheet component that can be semantically inserted on canvas (i.e. the screenshot above).
The component should query the touch-capabilities of the device (i.e. PlatformService.isTouch) to figure out wether the actions sheet should be shown modally using ModalController.showActionSheet (when isTouch = true) or "on canvas" styled as mentioned above (isTouch = false).

Refactor: The existing kirby-action-sheet should be split into a new subcomponent/molecule (kirby-action-sheet-popout?) that only contains the popout/card and a new wrapper component (similar to the existing kirby-action-sheet) that wraps the card + a close/cancel button (to be displayed inside the modal window).

That would end up in target projects using the actions sheet as:

<kirby-action-sheet [items]="items" cancelButtonText ="Undo" [title]="My title" [subtitle]="Something else...">
  <kirby-icon name="more">
</kirby-action-sheet>

Consider:

  • Should we default to iconName="more"? I.e. make it optional to slot an icon?
  • Should we allow/enforce the target project to supply the button (with the icon inside)?

@bommariusser Do we always want to show the button as a falafal? Or could the button include text?

@jakobe jakobe modified the milestones: Summer 2020 - Masterplanning 3 (tablet enhancements), Desktop ready Kirby Feb 23, 2021
@flemcito flemcito self-assigned this Mar 18, 2021
@alxzak alxzak modified the milestones: Desktop ready Kirby, Masterplanning 7 May 3, 2021
@alxzak alxzak modified the milestones: Masterplanning 7, Masterplanning 8 Jun 14, 2021
@alxzak alxzak assigned jakobe and unassigned flemcito Jun 14, 2021
@jkaltoft jkaltoft changed the title [Enhancement] Responsive Actionsheet (On large screens) [BLOCKED][Enhancement] Responsive Actionsheet (On large screens) Aug 26, 2021
@jkaltoft jkaltoft assigned jkaltoft and unassigned jkaltoft and MadsBuchmann Aug 26, 2021
@jkaltoft jkaltoft modified the milestones: Masterplanning 8, Masterplanning 9 Sep 2, 2021
@alxzak alxzak removed this from the Masterplanning 9 milestone Sep 13, 2021
@RasmusKjeldgaard
Copy link
Collaborator

Semi-blocked by #1932 as we want to experiment with the ionic-popover before deciding on the implementation.

@MadsBuchmann MadsBuchmann mentioned this issue Jun 13, 2022
26 tasks
@jkaltoft jkaltoft moved this to 💤 Impeeded in Kirby Jul 14, 2022
@RasmusKjeldgaard
Copy link
Collaborator

Replaced by the redesign described in #2807, where action sheet shares the dropdown-design and most of its behavior on both touch and desktop

@github-project-automation github-project-automation bot moved this from 💤 Impeeded to ✅ Done in Kirby Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Action Sheet enhancement New feature or request priority 1 Tablet Tablet support related issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants