-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLOCKED][Enhancement] Responsive Actionsheet (On large screens) #404
Comments
"parked" til after 1st release for now - might change if web is prioritized differently. |
sure @labanos lad os tage det mandag :) det er nok mere >720 og ikke bare kun web :) |
Tech refinement:
This would make it possible to style the "popout" i.e. the card in a similar way we do it on the dropdown (absolute positioned with z-index, but without left-right-top-bottom, so it renders below the button) The above should be wrapped in a kirby-action-sheet component that can be semantically inserted on canvas (i.e. the screenshot above). Refactor: The existing kirby-action-sheet should be split into a new subcomponent/molecule ( That would end up in target projects using the actions sheet as:
Consider:
@bommariusser Do we always want to show the button as a falafal? Or could the button include text? |
Semi-blocked by #1932 as we want to experiment with the ionic-popover before deciding on the implementation. |
Replaced by the redesign described in #2807, where action sheet shares the dropdown-design and most of its behavior on both touch and desktop |
Is your enhancement request related to a problem? Please describe.
The actionsheet looks the same on small and big screens, but thats not intended.
we want the actionsheet to be visually different on big screens.
See example in browser: https://cookbook.kirby.design/examples/page/custom-title
See also screenshot below
TODO:
The text was updated successfully, but these errors were encountered: