Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add dynamic toolbar height and refine layout #2219

Closed
14 of 16 tasks
Tracked by #1155
mictro opened this issue May 4, 2022 · 0 comments · Fixed by #2281
Closed
14 of 16 tasks
Tracked by #1155

[Enhancement] Add dynamic toolbar height and refine layout #2219

mictro opened this issue May 4, 2022 · 0 comments · Fixed by #2281
Assignees
Labels
component:Page enhancement New feature or request

Comments

@mictro
Copy link
Contributor

mictro commented May 4, 2022

Describe the solution you'd like

  • Set the height of the toolbar should be set depending on the size of the screen set as follows*:
    • >= medium: 'xxxxl'/64px
    • < medium: 'xxxl'/56px (default)
    • 'xxl'/48px (if the phone is an iPhone with a notch*)
      * The presence of a notch on the iPhone is not easily detectable but it has been agreed that a defined ios-safe-area-top above 32px will be interpreted as an iPhone with a notch
  • Add a 1px 'semi-light' bottom border to the toolbar when content is scrolled - see [Enhancement] Page toolbar needs dropshadow in scroll state #2040 for details
  • Increase the distance between the toolbar and the page content - ask UX.
  • Restrict the toolbar button styling to icon-only buttons on kirby-page avoiding kirby-modal.
  • Extend toolbar styling to kirby-action to work with templates not using the kirby-page-action element.

Have you considered any alternatives?

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the stable branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@mictro mictro added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels May 4, 2022
@mictro mictro changed the title [Enhancement] Dynamic toolbar height and size adjustments [Enhancement] Add dynamic toolbar height and adjust existing element sizes May 4, 2022
@mictro mictro changed the title [Enhancement] Add dynamic toolbar height and adjust existing element sizes [Enhancement] Add dynamic toolbar height and adjust preexisting sizes May 4, 2022
@mictro mictro changed the title [Enhancement] Add dynamic toolbar height and adjust preexisting sizes [Enhancement] Add dynamic toolbar height and fine-tune sizes May 4, 2022
@mictro mictro changed the title [Enhancement] Add dynamic toolbar height and fine-tune sizes [Enhancement] Add dynamic toolbar height and refine sizes May 4, 2022
@mictro mictro changed the title [Enhancement] Add dynamic toolbar height and refine sizes [Enhancement] Add dynamic toolbar height and refine layout May 4, 2022
@mictro mictro added priority 1 component:Page and removed NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed labels May 4, 2022
@mictro mictro added this to the Page toolbar enhancements milestone May 4, 2022
@mictro mictro added 👶🏻 New For new issues before prioritisation and refinement and removed priority 1 labels May 5, 2022
@mictro mictro added this to Kirby May 5, 2022
@mictro mictro moved this to 📙 Backlog in Kirby May 5, 2022
@mictro mictro moved this from 📙 Backlog to 🚀 In Progress in Kirby May 5, 2022
@mictro mictro self-assigned this May 5, 2022
@alxzak alxzak removed the 👶🏻 New For new issues before prioritisation and refinement label May 9, 2022
@mictro mictro moved this from 🚀 In Progress to 🔎 Review pending in Kirby May 11, 2022
@mictro mictro moved this from 🔎 Review pending to 💤 Impeeded in Kirby May 11, 2022
@mictro mictro moved this from 💤 Impeeded to 🚀 In Progress in Kirby May 11, 2022
@mictro mictro linked a pull request May 18, 2022 that will close this issue
7 tasks
@mictro mictro moved this from 🚀 In Progress to 💤 Impeeded in Kirby May 23, 2022
@mictro mictro changed the title [Enhancement] Add dynamic toolbar height and refine layout Add dynamic toolbar height and refine layout May 31, 2022
@mictro mictro changed the title Add dynamic toolbar height and refine layout [Enhancement] Add dynamic toolbar height and refine layout May 31, 2022
@mictro mictro moved this from 💤 Impeeded to 🔎 Review pending in Kirby May 31, 2022
@jkaltoft jkaltoft moved this from 🔎 Review pending to 👀 Review in progess in Kirby Jun 1, 2022
@mictro mictro closed this as completed Jun 9, 2022
Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Page enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants