-
Notifications
You must be signed in to change notification settings - Fork 24
Closed
Description
- I have written a good issue
Describe the enhancement
UX has made some small visual changes to the toolbar on mobile + desktop (before and after scroll):
- Toolbar on mobile should always be xxl/56px (effectively reverts changes done in [Enhancement] Add dynamic toolbar height and refine layout #2219)
- Toolbar on desktop should always be xxxxxl/72px (new size should be added to sizes-ramp)
- Toolbar separator bottom-line should always be visible on desktop
- Except when tab-navigation is used
- Toolbar background should be Kirby black + 1% transparent
- Please note: the design specs shows a translucent toolbar, but as this has implications when using tab navigation, this change is postponed to [Enhancement] Translucent toolbar and tab navigation #3247
-
Toolbar buttons should have 16px spacing on the right on mobile and 24px on desktop
Please note: This enhancement will be implemented in a separate issue when we fix the spacing of toolbar action buttons and space available for toolbar title (is currently partly overlapped by toolbar buttons)
Describe the solution you'd like
Have you considered any alternatives?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Refinement
- Request that the issue is UX refined; do not proceed until this is done.
- Request that the issue is tech refined; do not proceed until this is done.
Implementation
The contributor who wants to implement this issue should:
- Make sure you have read: "Before you get coding".
- Signal to others you are working on the issue by assigning yourself.
- Create a branch from the develop branch following our branch naming convention.
- Publish a WIP implementation to Github as a draft PR and ask for feedback.
- Make sure you have implemented tests following the guidelines in: "The good: Test".
- Update the cookbook with examples and showcases.
Review
Once the issue has been implemented and is ready for review:
- Do a self-review.
- Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request
Type
Projects
Status
✅ Done