Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: toolbar and header visual changes #3041

Merged
merged 22 commits into from
May 15, 2023
Merged

Enhancement: toolbar and header visual changes #3041

merged 22 commits into from
May 15, 2023

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented May 8, 2023

Which issue does this PR close?

This PR closes #3040

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-3040-toolbar-and-header-visual-changes May 8, 2023 10:46 Inactive
@github-actions github-actions bot temporarily deployed to pr-3040-toolbar-and-header-visual-changes May 8, 2023 10:47 Inactive
@github-actions github-actions bot temporarily deployed to pr-3040-toolbar-and-header-visual-changes May 8, 2023 15:34 Inactive
@github-actions github-actions bot temporarily deployed to pr-3040-toolbar-and-header-visual-changes May 9, 2023 13:13 Inactive
@github-actions github-actions bot temporarily deployed to pr-3040-toolbar-and-header-visual-changes May 12, 2023 06:45 Inactive
@jakobe jakobe marked this pull request as ready for review May 12, 2023 07:53
@jakobe jakobe requested a review from jkaltoft as a code owner May 12, 2023 07:53
@github-actions github-actions bot temporarily deployed to pr-3040-toolbar-and-header-visual-changes May 12, 2023 07:59 Inactive
@jakobe jakobe added the feature Add this PR to the changelog as a feature label May 12, 2023
mark-drastrup
mark-drastrup reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @jakobe! I only have some minor comments :)

libs/designsystem/page/src/page.component.spec.ts Outdated Show resolved Hide resolved
libs/designsystem/page/src/page.component.spec.ts Outdated Show resolved Hide resolved
libs/designsystem/page/src/page.component.spec.ts Show resolved Hide resolved
libs/designsystem/page/src/page.component.spec.ts Show resolved Hide resolved
libs/designsystem/page/src/page.component.spec.ts Show resolved Hide resolved
libs/designsystem/tab-navigation/src/tab-navigation/tab-navigation.component.scss Outdated Show resolved Hide resolved
jakobe and others added 2 commits May 15, 2023 13:47
@jakobe @mark-drastrup
test: typo
67b44db 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@jakobe @mark-drastrup
test: typo
0cd0dd0 
Co-authored-by: mark-drastrup <mark.drastrup@gmail.com>
@github-actions github-actions bot temporarily deployed to pr-3040-toolbar-and-header-visual-changes May 15, 2023 11:52 Inactive
@jakobe jakobe requested a review from mark-drastrup May 15, 2023 12:07
mark-drastrup
mark-drastrup approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakobe jakobe enabled auto-merge (squash) May 15, 2023 12:14
@jakobe jakobe merged commit 177068b into develop May 15, 2023
@jakobe jakobe deleted the enhancement/3040-toolbar-and-header-visual-changes branch May 15, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-drastrup mark-drastrup mark-drastrup approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

@RasmusKjeldgaard RasmusKjeldgaard Awaiting requested review from RasmusKjeldgaard

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Toolbar and header visual changes
2 participants
@jakobe @mark-drastrup