Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Tabbar with medium text badge #2432

Closed
3 of 11 tasks
henrikvoetmand opened this issue Aug 22, 2022 · 2 comments · Fixed by #2555
Closed
3 of 11 tasks

[Enhancement] Tabbar with medium text badge #2432

henrikvoetmand opened this issue Aug 22, 2022 · 2 comments · Fixed by #2555
Assignees
Labels
enhancement New feature or request

Comments

@henrikvoetmand
Copy link
Collaborator

henrikvoetmand commented Aug 22, 2022

Describe the enhancement

DRB is working to enhance the tabbar to make is possible to see the number of unread messages. A medium badge with text is used to show this info. The placement and alignment of the badge with text is not correct.

Describe the solution you'd like

Adjust the position and the alignment (left-align) of the badge.

Have you considered any alternatives?

No

Are there any additional context?

Text-badge-layout-issue

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@henrikvoetmand henrikvoetmand added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Aug 22, 2022
@henrikvoetmand henrikvoetmand added this to the M13 ( 16/6 - 7/9 ) milestone Aug 22, 2022
@henrikvoetmand henrikvoetmand moved this to 📙 Backlog in Kirby Aug 22, 2022
@henrikvoetmand henrikvoetmand removed this from the M13 ( 16/6 - 7/9 ) milestone Aug 22, 2022
@RasmusKjeldgaard RasmusKjeldgaard linked a pull request Aug 23, 2022 that will close this issue
7 tasks
@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Aug 23, 2022

I have linked a draft that illustrates how this should look for mobile view.

@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Aug 25, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this from 📙 Backlog to 🔎 Review pending in Kirby Aug 25, 2022
@RasmusKjeldgaard RasmusKjeldgaard removed 👶🏻 New For new issues before prioritisation and refinement NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Aug 30, 2022
@RasmusKjeldgaard RasmusKjeldgaard removed their assignment Aug 30, 2022
@henrikvoetmand
Copy link
Collaborator Author

UPDATE!
The requirements for the tablet and the desktop version has changed. The mobile implementation/design is NOT changed.
On tablet and desktop we want to place the badge to the right of menu point label. See below:

Text-badge-layout-issue-desktop

@RasmusKjeldgaard RasmusKjeldgaard moved this from 🔎 Review pending to 📙 Backlog in Kirby Sep 9, 2022
@mictro mictro self-assigned this Sep 13, 2022
@mictro mictro moved this from 📙 Backlog to 🚀 In Progress in Kirby Sep 13, 2022
@mictro mictro moved this from 🚀 In Progress to 💤 Impeeded in Kirby Sep 22, 2022
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💤 Impeeded to 🚀 In Progress in Kirby Sep 22, 2022
@mictro mictro moved this from 🚀 In Progress to 💤 Impeeded in Kirby Oct 10, 2022
@mictro mictro moved this from 💤 Impeeded to 🚀 In Progress in Kirby Oct 13, 2022
@mictro mictro removed their assignment Oct 19, 2022
@mictro mictro moved this from 🚀 In Progress to 📙 Backlog in Kirby Oct 19, 2022
@mictro mictro self-assigned this Oct 20, 2022
@mictro mictro moved this from 📙 Backlog to 🚀 In Progress in Kirby Oct 20, 2022
@mictro mictro moved this from 🚀 In Progress to 🔎 Review pending in Kirby Oct 21, 2022
@jkaltoft jkaltoft moved this from 🔎 Review pending to 👀 Review in progess in Kirby Oct 24, 2022
Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
3 participants