Make badge in tab-bar grow/expand right #2430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jkaltoft
requested changes
Aug 24, 2022
libs/designsystem/src/lib/components/tabs/tab-button/tab-button.component.scss
Outdated
Show resolved
Hide resolved
RasmusKjeldgaard
force-pushed
the
enhancement/badge-position-in-tabs
branch
from
5e0196d to
1f94a13
Compare
jkaltoft
approved these changes
Aug 25, 2022
| // Magic values here as we have no tokens that gives | ||
| // badge the correct position in relation to the tab icon | ||
| --kirby-badge-top: -1em; | ||
| --kirby-badge-left: 1.4em; |
There was a problem hiding this comment.
You could argue that this is redundant since you're declaring --kirby-badge-left with the same value as it already had - but I think it's also ok to leave it for clarity.
|
Unfortunately requirements changed after implementation so closing this PR. Can still be used as inspiration for the mobile part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2432
What is the new behavior?
Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.