Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Kirby Data Table Row Height #2553

Closed
1 of 11 tasks
jungloev opened this issue Oct 19, 2022 · 1 comment · Fixed by #2595
Closed
1 of 11 tasks

[Enhancement] Kirby Data Table Row Height #2553

jungloev opened this issue Oct 19, 2022 · 1 comment · Fixed by #2595
Assignees
Labels
enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@jungloev
Copy link

Describe the enhancement

Row heights are too high for 14px font and larger data tables.

Describe the solution you'd like

Row height is calculated by padding: 16px and line-height: 16px = 48px. Rows should be 44px to look good.

Reduce default padding to 4px 16px and set min-height to 44px. This would also allow visualy larger objects like toggle (32px height) to fit in table-rows without breaking the vertical rythm.

*min-height is already implemented in dropdown pop-overs

Have you considered any alternatives?

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@jungloev jungloev added enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed labels Oct 19, 2022
@mark-drastrup mark-drastrup self-assigned this Nov 9, 2022
@mark-drastrup mark-drastrup moved this to 🔎 Review pending in Kirby Nov 10, 2022
@mark-drastrup mark-drastrup moved this from 🔎 Review pending to 👀 Review in progess in Kirby Nov 11, 2022
@mark-drastrup
Copy link
Contributor

Hi @jungloev :) Do we expect additional table row heights in the future? If so, then we will take that into account, so it will be easier to add additional height when needed :)

Repository owner moved this from 👀 Review in progess to ✅ Done in Kirby Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants