Adjust table row default height to 44px #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
pr-2553-data-table-row-height
libs/designsystem/src/lib/components/data-table/table/table.component.scss
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
pr-2553-data-table-row-height
| @@ -40,7 +40,8 @@ th { | |||
| } | |||
|
|
|||
| td { | |||
| padding: utils.size('s'); | |||
| height: 44px; | |||
There was a problem hiding this comment.
Would be good to quickly investigate if we expect additional table cell heights in the future. Then we could add this to variables similar to item-heights:
$item-heights: (
m: 56px,
s: 44px,
xs: 32px,
) !default;
Or even modify the name of that one if they should be similar!
There was a problem hiding this comment.
@RasmusKjeldgaard we still haven't received any response whether we expect additional table cel height in the future or not. Should we push for a response or should we add it later, if it becomes necessary? :)
There was a problem hiding this comment.
Let us extract it to a variable and get on with it! :D
github-actions
bot
temporarily deployed
to
pr-2553-data-table-row-height
RasmusKjeldgaard
approved these changes
Dec 19, 2022
github-actions
bot
temporarily deployed
to
pr-2553-data-table-row-height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2553
What is the new behavior?
The table cells now have a padding and a height to ensure that the default height of the table row is 44px. The cell height will still grow if the content is higher.
Does this PR introduce a breaking change?
Are there any additional context?
In #2553 it is suggested to use
min-height. As far as I can seemin-heightcannot be used cannot be used to table elements, and therefore I have usedheightinstead.Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.