Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust table row default height to 44px #2595

Merged
merged 7 commits into from
Dec 19, 2022
Merged

Adjust table row default height to 44px #2595

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4d43ce
Refactor table cell styling to ensure a default height of 44px
mark-drastrup Nov 10, 2022
62436a0
Update test for table cell styling
mark-drastrup Nov 10, 2022
bf0d5d5
Merge branch 'develop' into enhancement/2553-data-table-row-height
mark-drastrup Nov 11, 2022
6b2b0a0
Merge branch 'develop' into enhancement/2553-data-table-row-height
mark-drastrup Nov 29, 2022
45e094c
Merge branch 'develop' into enhancement/2553-data-table-row-height
mark-drastrup Dec 19, 2022
986bcc1
Extract the cell height to a variable
mark-drastrup Dec 19, 2022
da505a5
Merge branch 'develop' into enhancement/2553-data-table-row-height
mark-drastrup Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/designsystem/src/lib/components/data-table/table/table.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ th {
}

td {
padding: utils.size('s');
height: 44px;
RasmusKjeldgaard marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to quickly investigate if we expect additional table cell heights in the future. Then we could add this to variables similar to item-heights:

$item-heights: (
  m: 56px,
  s: 44px,
  xs: 32px,
) !default;

Or even modify the name of that one if they should be similar!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RasmusKjeldgaard we still haven't received any response whether we expect additional table cel height in the future or not. Should we push for a response or should we add it later, if it becomes necessary? :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us extract it to a variable and get on with it! :D

padding: utils.size('xxxs') utils.size('s');
font-weight: utils.font-weight('normal');
font-size: utils.font-size('s');
color: utils.get-text-color('black');
Expand Down
2 changes: 1 addition & 1 deletion libs/designsystem/src/lib/components/data-table/table/table.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ describe('TableComponent', () => {

it('should style [tbody] cells correctly', () => {
expect(element.children.namedItem('tbody').firstChild.firstChild).toHaveComputedStyle({
padding: `${size('s')}`,
padding: `${size('xxxs')} ${size('s')}`,
'font-weight': fontWeight('normal'),
'font-size': fontSize('s'),
color: getTextColor('black'),
Expand Down