Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COMPONENT] New Kirby modal component / module based on Ionic's default modals #2585

Closed
1 of 11 tasks
mark-drastrup opened this issue Nov 4, 2022 · 0 comments · Fixed by #2679
Closed
1 of 11 tasks
Assignees
Labels
component NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@mark-drastrup
Copy link
Contributor

Describe the solution you'd like

New modal based on the default Ionic modals. This is part of the proces to simplify the Kirby modal and at the same time make it desktop ready. The goal is to make either a stand alone component (dependent on Angular 14) or a new module. By doing it this way we can work on the new modal, without making breaking changes to the old modal.

After making one or two modals, both as inline modals and programatically available through a modalController, the ambition is to make a RFC to get some input on the direction we are headed. Additionally, by starting the proces of refactoring the modals and seeing Ionic's default output for desktop modals, we are better equipped to talk about the subject with the UX group.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@mark-drastrup mark-drastrup added component NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Nov 4, 2022
@mark-drastrup mark-drastrup self-assigned this Nov 4, 2022
@alxzak alxzak removed the 👶🏻 New For new issues before prioritisation and refinement label Nov 14, 2022
@mark-drastrup mark-drastrup moved this to 🚀 In Progress in Kirby Nov 16, 2022
@mark-drastrup mark-drastrup moved this from 🚀 In Progress to 🔎 Review pending in Kirby Dec 19, 2022
@github-project-automation github-project-automation bot moved this from 🔎 Review pending to ✅ Done in Kirby Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants