Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] apply basic Kirby styles to the new modal #2586

Closed
1 of 11 tasks
mark-drastrup opened this issue Nov 4, 2022 · 2 comments
Closed
1 of 11 tasks

[Enhancement] apply basic Kirby styles to the new modal #2586

mark-drastrup opened this issue Nov 4, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed stale Automatically applied when there is no activity on an issue or PR

Comments

@mark-drastrup
Copy link
Contributor

Describe the enhancement

After implementing the new modal as described in #2585, we should apply basic Kirby styles to it, so we can give it the same appearance as the current modal.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@mark-drastrup mark-drastrup added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Nov 4, 2022
@mark-drastrup mark-drastrup self-assigned this Nov 4, 2022
@stale
Copy link

stale bot commented Jan 14, 2023

This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Automatically applied when there is no activity on an issue or PR label Jan 14, 2023
@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been closed due to inactivity. Please open a new issue if it becomes relevant again.

@stale stale bot closed this as completed Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed stale Automatically applied when there is no activity on an issue or PR
Projects
None yet
Development

No branches or pull requests

1 participant