Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize content scroll listening in modal #3044

Closed
1 of 11 tasks
RasmusKjeldgaard opened this issue May 11, 2023 · 2 comments · Fixed by #3163
Closed
1 of 11 tasks

[Enhancement] Optimize content scroll listening in modal #3044

RasmusKjeldgaard opened this issue May 11, 2023 · 2 comments · Fixed by #3163
Assignees
Labels
enhancement New feature or request Technical and design debt A collection of technical and design debt

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the enhancement

#2995 implements scroll-listening via the (ionScroll) event emitter on ion-content, for showing/hiding the horizontal divider below the title/header area on mobile.

Currently the listening is always enabled even though the divider line is always shown on desktop, no matter the scroll state of ion-content.

Describe the solution you'd like

Ideally we want to listen to the current breakpoint and enable/disable the subscription accordingly.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@RasmusKjeldgaard RasmusKjeldgaard added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels May 11, 2023
@alxzak alxzak added the Technical and design debt A collection of technical and design debt label Jun 6, 2023
@stale
Copy link

stale bot commented Aug 18, 2023

This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Automatically applied when there is no activity on an issue or PR label Aug 18, 2023
@stale
Copy link

stale bot commented Oct 29, 2023

This issue has been closed due to inactivity. Please open a new issue if it becomes relevant again.

@stale stale bot closed this as completed Oct 29, 2023
@stale stale bot removed the stale Automatically applied when there is no activity on an issue or PR label Oct 30, 2023
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Oct 30, 2023
@alxzak alxzak moved this to 🚀 In Progress in Kirby Sprints Dec 13, 2023
@github-project-automation github-project-automation bot moved this from 🚀 In Progress to ✅ Done in Kirby Sprints Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Technical and design debt A collection of technical and design debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants