Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Optimize content scroll listening in modal #3163

Merged
merged 29 commits into from
Dec 18, 2023
Merged

Modal: Optimize content scroll listening in modal #3163

merged 29 commits into from
Dec 18, 2023

Conversation

AgreSanGit
Copy link
Contributor

Which issue does this PR close?

This PR closes #3044

What is the new behavior?

Optimize content scroll listening in modal. Now listening to the current breakpoint and enabling/disabling the subscription accordingly for ionScroll. On desktop disable IonScroll listening.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit self-assigned this Jul 10, 2023
@AgreSanGit AgreSanGit added the feature Add this PR to the changelog as a feature label Jul 10, 2023
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal July 12, 2023 13:58 Inactive
@AgreSanGit AgreSanGit marked this pull request as ready for review July 18, 2023 08:04
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal July 18, 2023 08:13 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal July 25, 2023 09:24 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal August 4, 2023 12:43 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal August 31, 2023 08:39 Inactive
@AgreSanGit AgreSanGit changed the title Optimize content scroll listening in modal Modal: Optimize content scroll listening in modal Sep 14, 2023
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal October 12, 2023 12:58 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal October 13, 2023 08:14 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal October 13, 2023 13:08 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal October 19, 2023 08:34 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal October 27, 2023 11:35 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal November 16, 2023 10:05 Inactive
@RasmusKjeldgaard RasmusKjeldgaard requested review from RasmusKjeldgaard and removed request for RasmusKjeldgaard November 21, 2023 14:02
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal November 24, 2023 08:34 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal November 24, 2023 09:17 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal November 24, 2023 09:25 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal November 24, 2023 09:46 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal December 14, 2023 08:13 Inactive
@github-actions github-actions bot had a problem deploying to pr-3044-optimize-content-scroll-listening-in-modal December 14, 2023 08:13 Failure
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal December 14, 2023 09:40 Inactive
@github-actions github-actions bot temporarily deployed to pr-3044-optimize-content-scroll-listening-in-modal December 15, 2023 08:59 Inactive
@jakobe jakobe enabled auto-merge (squash) December 18, 2023 13:08
@jakobe jakobe merged commit a9df64d into develop Dec 18, 2023
4 of 5 checks passed
@jakobe jakobe deleted the enhancement/3044-optimize-content-scroll-listening-in-modal branch December 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobe jakobe jakobe approved these changes

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard left review comments

Assignees

@AgreSanGit AgreSanGit

Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize content scroll listening in modal
4 participants
@AgreSanGit @jakobe @RasmusKjeldgaard @mark-drastrup