Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Toolbar, header and action buttons visual adjustments #3079

Closed
21 of 31 tasks
jakobe opened this issue May 26, 2023 · 0 comments · Fixed by #3073
Closed
21 of 31 tasks

[Enhancement] Toolbar, header and action buttons visual adjustments #3079

jakobe opened this issue May 26, 2023 · 0 comments · Fixed by #3073
Assignees
Labels
enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone

Comments

@jakobe
Copy link
Collaborator

jakobe commented May 26, 2023

Describe the enhancement

Describe the solution you'd like

  • Remove padding-top on content when the new kirby-header component is present

  • Kirby header on small screens:

    • only 8px margin-top, when avatar or progress-circle is present:
      image
  • Remove 2px bottom-margin from h1 when used in key value scenario:
    image

  • Remove column-gap from div.container when styled as grid on large screens to avoid double spacing (16px padding is already added to div.title-container):
    image
    and:
    image

  • Also consider changing div.title-container horizontal padding to margin

  • Toolbar:

    • Remove 4px horizontal padding from ion-toolbar

    • Horizontal padding should be:

      • Small screens: 16px
        image
      • Large screens: 24px
        image
    • Action buttons:

      • Should have no margin-right
      • Should have 8px gap between them
      • Should have 8px margin-left
        image
  • Action buttons on canvas:

    • Should have 8px margin-left
    • Should have 8px gap between them
    • Should have 8px margin-right
      image
  • Toolbar title width should account for action buttons:
    ❌ Current behaviour:
    image
    ✅ Expected behaviour:
    image

Have you considered any alternatives?

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@jakobe jakobe added enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone labels May 26, 2023
@jakobe jakobe added this to Kirby May 26, 2023
@jakobe jakobe moved this to 📙 Backlog in Kirby May 26, 2023
@jakobe jakobe self-assigned this Jun 15, 2023
@jakobe jakobe moved this from 📙 Backlog to 🚀 In Progress in Kirby Jun 15, 2023
@jakobe jakobe moved this from 🚀 In Progress to 👀 Review in progress in Kirby Jun 26, 2023
@github-project-automation github-project-automation bot moved this from 👀 Review in progress to ✅ Done in Kirby Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NOT Prioritized Issue not yet prioritized and added to a Milestone
Projects
Archived in project
1 participant