Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual adjustments for header, toolbar and action buttons + add missing tests for header and action group components #3073

Merged
merged 28 commits into from
Jun 26, 2023
Merged

Visual adjustments for header, toolbar and action buttons + add missing tests for header and action group components #3073

merged 28 commits into from
Jun 26, 2023

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented May 24, 2023 •
edited
Loading

Which issue does this PR close?

This PR closes #3069 and closes #3079

What is the new behavior?

Visual adjustments to action group, header, toolbar and action buttons + adding missing tests

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe added the ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby label May 24, 2023
@github-actions github-actions bot temporarily deployed to pr-3069-add-missing-tests-for-header-and-action-group-components June 15, 2023 15:14 Inactive
@github-actions github-actions bot temporarily deployed to pr-3069-add-missing-tests-for-header-and-action-group-components June 20, 2023 09:21 Inactive
@github-actions github-actions bot temporarily deployed to pr-3069-add-missing-tests-for-header-and-action-group-components June 21, 2023 10:08 Inactive
@jakobe jakobe added fix Add this PR to the changelog as a bugfix and removed ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby labels Jun 22, 2023
@github-actions github-actions bot temporarily deployed to pr-3069-add-missing-tests-for-header-and-action-group-components June 23, 2023 08:17 Inactive
@github-actions github-actions bot temporarily deployed to pr-3069-add-missing-tests-for-header-and-action-group-components June 23, 2023 08:28 Inactive
@jakobe jakobe marked this pull request as ready for review June 23, 2023 12:54
@jakobe jakobe requested a review from jkaltoft as a code owner June 23, 2023 12:54
@jakobe jakobe changed the title Housekeeping/3069 add missing tests for header and action group components Visual adjustments for header, toolbar and action buttons + add missing tests for header and action group components Jun 23, 2023
@github-actions github-actions bot temporarily deployed to pr-3069-add-missing-tests-for-header-and-action-group-components June 23, 2023 13:00 Inactive
@jakobe jakobe requested a review from mark-drastrup June 26, 2023 05:39
mark-drastrup
mark-drastrup approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are the PR master! Approved ✅

@jakobe jakobe merged commit 1962f20 into develop Jun 26, 2023
@jakobe jakobe deleted the housekeeping/3069-add-missing-tests-for-header-and-action-group-components branch June 26, 2023 11:04
@jakobe jakobe mentioned this pull request Jun 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-drastrup mark-drastrup mark-drastrup approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

Assignees
No one assigned
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Milestone
No milestone
2 participants
@jakobe @mark-drastrup