Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] Add missing tests for Header & Action Group components #3069

Closed
1 task done
jakobe opened this issue May 24, 2023 · 0 comments · Fixed by #3073
Closed
1 task done

[Housekeeping] Add missing tests for Header & Action Group components #3069

jakobe opened this issue May 24, 2023 · 0 comments · Fixed by #3073
Assignees
@jakobe
Labels
housekeeping Technical and design debt A collection of technical and design debt

Comments

@jakobe
Copy link
Collaborator

jakobe commented May 24, 2023

Describe the housekeeping request

Due to deadlines and time constraints we had to cut corners when implementing the header and action group components.

We should add these tests now to guard against regressions in the future.

Have you considered any alternatives?

No.

Are there any additional context?

No.
@jakobe jakobe added NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement housekeeping labels May 24, 2023
@jakobe jakobe self-assigned this May 24, 2023
@jakobe jakobe added this to Kirby May 24, 2023
@jakobe jakobe changed the title [Housekeeping] Add tests for header & action groupcomponents [Housekeeping] Add tests for header & action group components May 24, 2023
@jakobe jakobe moved this to 📙 Backlog in Kirby May 24, 2023
@jakobe jakobe changed the title [Housekeeping] Add tests for header & action group components [Housekeeping] Add missing tests for Header & Action Group components May 24, 2023
@jakobe jakobe moved this from 📙 Backlog to 🚀 In Progress in Kirby May 24, 2023
@jakobe jakobe mentioned this issue May 24, 2023
Merged
8 tasks
@jakobe jakobe mentioned this issue Jun 14, 2023
Merged
6 tasks
@RasmusKjeldgaard RasmusKjeldgaard added Technical and design debt A collection of technical and design debt and removed NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Jun 15, 2023
@jakobe jakobe moved this from 🚀 In Progress to 👀 Review in progress in Kirby Jun 26, 2023
@github-project-automation github-project-automation bot moved this from 👀 Review in progress to ✅ Done in Kirby Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobe jakobe

Labels
housekeeping Technical and design debt A collection of technical and design debt
Projects
Kirby
Archived in project
Milestone
No milestone
2 participants
@jakobe @RasmusKjeldgaard