Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action Group: Render changes to visibleActions #3101

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented Jun 14, 2023

Which issue does this PR close?

This PR closes #3098

What is the new behavior?

Action Group collapses/shows buttons when changing visibleActions after init.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Tests will be added as part of fixing #3069

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • [ ] Make sure you have implemented tests following the guidelines in: "The good: Test".
  • [ ] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe added the fix Add this PR to the changelog as a bugfix label Jun 14, 2023
@jakobe jakobe changed the title Render changes to kirby-action-group.visibleActions Action Group: Render changes to visibleActions Jun 14, 2023
@github-actions github-actions bot temporarily deployed to pr-3098-action-group-doesnt-update-when-changing-visibleactions June 14, 2023 10:09 Inactive
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakobe great job as usual! My only comment is that it would be great to include some tests, but that is covered by #3069, right? :)

@jakobe
Copy link
Collaborator Author

jakobe commented Jun 15, 2023

@jakobe great job as usual! My only comment is that it would be great to include some tests, but that is covered by #3069, right? :)

Yeps 😊
image

@github-actions github-actions bot temporarily deployed to pr-3098-action-group-doesnt-update-when-changing-visibleactions June 15, 2023 06:07 Inactive
Copy link
Contributor

@mark-drastrup mark-drastrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mindblown!

@jakobe jakobe merged commit f490eb7 into develop Jun 15, 2023
@jakobe jakobe deleted the bug/3098-action-group-doesnt-update-when-changing-visibleactions branch June 15, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Action Group doesn't update when changing visibleActions
2 participants