Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Action Group doesn't update when changing visibleActions #3098

Closed
1 of 9 tasks
jakobe opened this issue Jun 14, 2023 · 0 comments · Fixed by #3101
Closed
1 of 9 tasks

[BUG] Action Group doesn't update when changing visibleActions #3098

jakobe opened this issue Jun 14, 2023 · 0 comments · Fixed by #3101
Assignees
Labels
Milestone

Comments

@jakobe
Copy link
Collaborator

jakobe commented Jun 14, 2023

Describe the bug

Action Group supports setting visibleActions, but it only works on init, it doesn't update the visible and collapsed buttons when changing the prop after init.

Describe how to reproduce the bug

  1. Add a kirby-action-group to a component's markup with 5 buttons, set visibleActions to 2.
  2. Update visibleActions after init (e.g. using a timeout or reacting to screen resize). Set visibleActions to 4.
  3. See no changes happen

Which Kirby version was used?

8.6.0

What was the expected behavior?

  • When updating visibleActions to a higher number than the initial number (e.g. from 2 -> 4) it should reveal those additional buttons
  • When updating visibleActions to a lower number than the initial number (e.g. from 4 -> 2) it should collapse those additional buttons

Add any screenshots

Please complete the following information:

  • OS: [e.g. Windows, MacOS, iOS]
  • Browser [e.g. Chrome, Safari]
  • Browser version [e.g. 22]

Are there any additional context?

No.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@jakobe jakobe added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Jun 14, 2023
@jakobe jakobe self-assigned this Jun 14, 2023
@jakobe jakobe removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Jun 14, 2023
@jakobe jakobe added this to Kirby Jun 14, 2023
@jakobe jakobe moved this to 🚀 In Progress in Kirby Jun 14, 2023
@jakobe jakobe added this to the Desktop ready milestone Jun 14, 2023
@jakobe jakobe moved this from 🚀 In Progress to 🔎 Review pending in Kirby Jun 14, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Review pending to ✅ Done in Kirby Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant