Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] kirby slides sometimes breaks when slides input is updated #3112

Closed
1 of 9 tasks
RasmusKjeldgaard opened this issue Jun 22, 2023 · 0 comments · Fixed by #3117
Closed
1 of 9 tasks

[BUG] kirby slides sometimes breaks when slides input is updated #3112

RasmusKjeldgaard opened this issue Jun 22, 2023 · 0 comments · Fixed by #3117
Assignees
Labels

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Jun 22, 2023

Describe the bug

When kirby-slides slides input is updated asynchronosly, but with a new object that causes us to re-render the individual slides without re-rendering the slides component itself, swiper.js no longer has the correct slides references to apply its styles to.

Expected:
image

Actual:
image

Describe how to reproduce the bug

Repro (and suggested fix) by @troelslenda: develop...reproduced-slides-bug

Which Kirby version was used?

8.7.0


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@RasmusKjeldgaard RasmusKjeldgaard added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Jun 22, 2023
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Jun 22, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this to 🚀 In Progress in Kirby Jun 22, 2023
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🚀 In Progress to 🔎 Review pending in Kirby Jun 22, 2023
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Jun 22, 2023
@RasmusKjeldgaard RasmusKjeldgaard changed the title [BUG] kirby slides sometimes loses config when slides input is updated [BUG] kirby slides sometimes breaks when slides input is updated Jun 22, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Review pending to ✅ Done in Kirby Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant