Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kirby-slides breaking when slides input is updated #3117

Merged

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes #3112

What is the new behavior?

When kirby-slides slides input is updated asynchronosly, but with a new object that causes us to re-render the individual slides without re-rendering the slides template itself, swiper.js no longer has the correct slide element references to apply its styles/calculations to, causing the slides to lose all config like slides per view, gap etc.
image

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

Troels Lenda Strand and others added 2 commits June 22, 2023 15:16
@github-actions github-actions bot temporarily deployed to pr-3112-kirby-slides-loses-config-on-update June 22, 2023 13:39 Inactive
Co-authored-by: Jakob Engelbrecht <jakob@basher.dk>
@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) June 22, 2023 13:52
@RasmusKjeldgaard RasmusKjeldgaard merged commit dab7eda into develop Jun 22, 2023
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/3112-kirby-slides-loses-config-on-update branch June 22, 2023 13:55
@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] kirby slides sometimes breaks when slides input is updated
2 participants