Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make kirby-list work out of the box when within kirby-accordion-item #3551

Closed
10 tasks
Fuzzy3 opened this issue Aug 21, 2024 · 0 comments · Fixed by #3552
Closed
10 tasks

[Enhancement] Make kirby-list work out of the box when within kirby-accordion-item #3551

Fuzzy3 opened this issue Aug 21, 2024 · 0 comments · Fixed by #3552
Assignees
Labels
enhancement New feature or request

Comments

@Fuzzy3
Copy link
Collaborator

Fuzzy3 commented Aug 21, 2024

Describe the enhancement

Improve integration of kirby-list within a kirby-accordion-item. When placing a kirby-list in an kirby-accordion-item it has too much spacing and is of wrong colors.

image

This may be solved by the integrator by adjusting some values - however in a design system the components should work together without relying on the integrator setting the right attributes.

Describe the solution you'd like

When placing a kirby-list within a kirby-accordion-item, the list should automatically turn transparent to follow the color scheme of the accordion and set the shape of the list to 'none'.


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@Fuzzy3 Fuzzy3 added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Aug 21, 2024
@Fuzzy3 Fuzzy3 linked a pull request Aug 21, 2024 that will close this issue
8 tasks
@Fuzzy3 Fuzzy3 removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Tech refined Needs Tech kickoff - solution outlined and agreed labels Aug 21, 2024
@Fuzzy3 Fuzzy3 added this to Kirby Aug 21, 2024
@Fuzzy3 Fuzzy3 moved this to 🔎 Review pending in Kirby Aug 21, 2024
@Fuzzy3 Fuzzy3 self-assigned this Aug 21, 2024
@github-project-automation github-project-automation bot moved this from 👀 Review in progress to ✅ Done in Kirby Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant