Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion: Support for lists within accordions #3552

Merged
merged 35 commits into from
Oct 2, 2024
Merged

Accordion: Support for lists within accordions #3552

merged 35 commits into from
Oct 2, 2024

Conversation

Fuzzy3
Copy link
Collaborator

@Fuzzy3 Fuzzy3 commented Aug 21, 2024 •
edited
Loading

Which issue does this PR close?

This PR closes #3551

What is the new behavior?

Placing kirby-list within kirby-accordion-item will make the list be styled correctly.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@Fuzzy3 Fuzzy3 linked an issue Aug 21, 2024 that may be closed by this pull request
[Enhancement] Make kirby-list work out of the box when within kirby-accordion-item #3551
Closed
10 tasks
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item August 21, 2024 11:03 Inactive
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item August 21, 2024 11:58 Inactive
@Fuzzy3 Fuzzy3 added the feature Add this PR to the changelog as a feature label Aug 23, 2024
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item August 23, 2024 09:59 Inactive
@Fuzzy3 Fuzzy3 marked this pull request as ready for review September 23, 2024 05:09
@Fuzzy3 Fuzzy3 requested a review from jkaltoft as a code owner September 23, 2024 05:09
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 23, 2024 05:13 Inactive
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 23, 2024 05:14 Inactive
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 23, 2024 05:22 Inactive
@Fuzzy3 Fuzzy3 force-pushed the 3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item branch from f2e7c13 to db0338a Compare September 24, 2024 04:32
@Fuzzy3
Merge branch 'develop' into 3551-enhancement-make-kirby-list-work-out…
715bb35 
…-of-the-box-when-within-kirby-accordion-item
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 24, 2024 04:40 Inactive
@Fuzzy3
Merge branch 'develop' into 3551-enhancement-make-kirby-list-work-out…
8211ca4 
…-of-the-box-when-within-kirby-accordion-item
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 24, 2024 04:57 Inactive
RasmusKjeldgaard
RasmusKjeldgaard reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice feature, good work!

apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/examples/accordion-example/examples/card-list.ts Show resolved Hide resolved
apps/cookbook/src/app/examples/accordion-example/examples/card-list.ts Show resolved Hide resolved
apps/cookbook/src/app/examples/accordion-example/examples/list.ts Show resolved Hide resolved
apps/cookbook/src/app/examples/accordion-example/accordion-example.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html.rej Outdated Show resolved Hide resolved
libs/designsystem/accordion/src/accordion-item.component.ts Outdated Show resolved Hide resolved
apps/cookbook/src/app/examples/accordion-example/examples/list.ts Outdated Show resolved Hide resolved
apps/cookbook/src/app/examples/accordion-example/examples/card-list.ts Outdated Show resolved Hide resolved
@Fuzzy3
PR Comments
1f8a163
@Fuzzy3
Merge remote-tracking branch 'refs/remotes/origin/3551-enhancement-ma…
503fd74 
…ke-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item' into 3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 26, 2024 09:34 Inactive
@Fuzzy3 @RasmusKjeldgaard
Update apps/cookbook/src/app/showcase/accordion-showcase/accordion-sh…
8f7a165 
…owcase.component.html

Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 26, 2024 10:26 Inactive
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 26, 2024 10:39 Inactive
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 26, 2024 10:40 Inactive
@Fuzzy3
Merge branch 'develop' into 3551-enhancement-make-kirby-list-work-out…
2be45ed 
…-of-the-box-when-within-kirby-accordion-item
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 27, 2024 08:53 Inactive
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item September 30, 2024 05:31 Inactive
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item October 1, 2024 04:36 Inactive
RasmusKjeldgaard
RasmusKjeldgaard reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!!

apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html Outdated Show resolved Hide resolved
apps/cookbook/src/app/showcase/accordion-showcase/accordion-showcase.component.html Outdated Show resolved Hide resolved
@Fuzzy3 @RasmusKjeldgaard
Apply suggestions from code review
1068f30 
Co-authored-by: RasmusKjeldgaard <rkk@bankdata.dk>
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item October 2, 2024 07:16 Inactive
@Fuzzy3 Fuzzy3 changed the title 3551 enhancement make kirby list work out of the box when within kirby accordion item Accordion: Support for lists within accordions Oct 2, 2024
@Fuzzy3
Merge branch 'develop' into 3551-enhancement-make-kirby-list-work-out…
dd6a8e7 
…-of-the-box-when-within-kirby-accordion-item
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item October 2, 2024 07:23 Inactive
Fuzzy3 added 3 commits October 2, 2024 11:13
@Fuzzy3
use h3 instead of p-tag so it looks proper
be5fb71
@Fuzzy3
Merge branch 'develop' into 3551-enhancement-make-kirby-list-work-out…
f32afd7 
…-of-the-box-when-within-kirby-accordion-item
@Fuzzy3
Merge branch '3551-enhancement-make-kirby-list-work-out-of-the-box-wh…
9fca4ec 
…en-within-kirby-accordion-item' of github.com:kirbydesign/designsystem into 3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item
@github-actions github-actions bot temporarily deployed to pr-3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item October 2, 2024 09:21 Inactive
@Fuzzy3 Fuzzy3 enabled auto-merge (squash) October 2, 2024 09:21
@Fuzzy3
Merge branch 'develop' into 3551-enhancement-make-kirby-list-work-out…
671d394 
…-of-the-box-when-within-kirby-accordion-item
@Fuzzy3 Fuzzy3 merged commit 78fe353 into develop Oct 2, 2024
7 of 12 checks passed
@Fuzzy3 Fuzzy3 deleted the 3551-enhancement-make-kirby-list-work-out-of-the-box-when-within-kirby-accordion-item branch October 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusKjeldgaard RasmusKjeldgaard RasmusKjeldgaard approved these changes

@jkaltoft jkaltoft Awaiting requested review from jkaltoft jkaltoft is a code owner

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make kirby-list work out of the box when within kirby-accordion-item
2 participants
@Fuzzy3 @RasmusKjeldgaard