Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some icons have built in <title> element #3675

Closed
1 of 9 tasks
jakobe opened this issue Oct 21, 2024 · 0 comments · Fixed by #3676
Closed
1 of 9 tasks

[BUG] Some icons have built in <title> element #3675

jakobe opened this issue Oct 21, 2024 · 0 comments · Fixed by #3676
Assignees
Labels

Comments

@jakobe
Copy link
Collaborator

jakobe commented Oct 21, 2024

Describe the bug

Some of the built in icons have both a <title> and <description> element hardcoded into the svg.
This shows up when hovering the icon:
image

Describe how to reproduce the bug

  1. Go to https://cookbook.kirby.design/#/home/showcase/item
  2. Hover the camera icon in the "Attachment" example
  3. See "communication/camera" is shown as the title

Which Kirby version was used?

v9.7.x

What was the expected behavior?

The icons shouldn't have a built-in title when used for decorative purpose. When used for action, e.g. within an icon only button, the title or arial-label should be set on the button.

Add any screenshots

Please complete the following information:

  • OS: [e.g. Windows, MacOS, iOS]
  • Browser [e.g. Chrome, Safari]
  • Browser version [e.g. 22]

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@jakobe jakobe added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Oct 21, 2024
@github-project-automation github-project-automation bot moved this to 📙 Backlog in Kirby Oct 21, 2024
@jakobe jakobe self-assigned this Oct 21, 2024
@jakobe jakobe moved this from 📙 Backlog to 🚀 In Progress in Kirby Oct 21, 2024
@jakobe jakobe removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Oct 21, 2024
@github-project-automation github-project-automation bot moved this from 🚀 In Progress to ✅ Done in Kirby Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant