Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon: remove title and desc element #3676

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jakobe
Copy link
Collaborator

@jakobe jakobe commented Oct 21, 2024

Which issue does this PR close?

This PR closes #3675

What is the new behavior?

Removes the <title> and <desc> elements from the icons that have them.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@jakobe jakobe added the fix Add this PR to the changelog as a bugfix label Oct 21, 2024
@jakobe jakobe merged commit ef408bc into develop Oct 21, 2024
12 checks passed
@jakobe jakobe deleted the bug/3675-some-icons-have-built-in-title-element branch October 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some icons have built in <title> element
2 participants