Deploy cookbook by merging develop into main #2561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Behavior has been changed: ArrowUp/ArrowDown no longer selects Item. Instead they move focus to next item. Updated test checks that items get focused. Extended with a key press on Enter to trigger select Item. When selecting an item it also programmatically gets focused.
- Key presses should not set selected item when dropdown is closed - ArrowDown and ArrowUp opens the dropdown - Space behaves like Enter (open and close dropdown)
Should not select item - only focus. Similar to arrow keys. Should only apply when dropdown is open.
If no item is selected then move focus to last item if ArrowUp Move focus to first item if ArrowDown.
…-before-close Add option to show an alert before dismissing modal
…ing-when-inner-action-item-is-clicked
…matically-closing-when-inner-action-item-is-clicked Fix no automatic close of fab-sheet on item click.
…irection Fix dropdown opening direction when button intersects bottom of viewport
* Change position of tabbar badges * Adjust md badge vertical position * Update libs/designsystem/src/lib/components/tabs/tab-button/tab-button.component.scss Co-authored-by: Jesper Kaltoft Vind <git@jesperkaltoft.dk> * Code Review Corrections * Remove errornously merge foced test Co-authored-by: Jesper Kaltoft Vind <git@jesperkaltoft.dk>
* Toggle 'clicked' class to prevent focus ring on click * Change comments to say 'dropdown' instead of 'modal' * Refactor to use Hostbinding to dynamically add 'clicked' class * Re-add method call, that was removed for test purposes
* Upgrade chart.js to v. 3.9.1 * Add type guard before accessing config.type * Create helper type guard function * Apply the type guard function where needed * Bump charts.js version in nested package.json * Remove skipLibCheck from tsconfig
* 7.2.1 * Update core version * Update changelog
RasmusKjeldgaard
changed the title
RasmusKjeldgaard
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main should be updated with the current state of develop as we have just released v7.2.1.
This will activate our current (soon to be obsolete) deployment logic.