Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing back navigation arrow on stacked pages #2691

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

mictro
Copy link
Contributor

@mictro mictro commented Dec 19, 2022

Which issue does this PR close?

This PR closes #2689

What is the new behavior?

Fix broken tab routing.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

Sorry, something went wrong.

@mictro mictro added the bug label Dec 19, 2022
@mictro mictro requested a review from jkaltoft as a code owner December 19, 2022 13:39
@mictro mictro linked an issue Dec 19, 2022 that may be closed by this pull request
8 tasks
@mictro mictro requested review from RasmusKjeldgaard and removed request for jkaltoft December 19, 2022 13:39
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of changing the title to be more changelog-friendly.

Remember to create an issue for re-introducing this functionality! 😊

@RasmusKjeldgaard RasmusKjeldgaard changed the title Fix broken tab routing Fix missing back navigation arrow on stacked pages Dec 19, 2022
@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Dec 19, 2022

One of the tests are failing, and it seems to be somewhat related to the page toolbar.
image

@github-actions github-actions bot temporarily deployed to pr-2689-bug-tab-routing-is-broken December 20, 2022 08:45 Inactive
@mictro mictro enabled auto-merge (squash) December 20, 2022 08:56
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still seeing the odd behavior in the flows app where the page title blinks 🤔

page-title-bug.mov

@mictro mictro merged commit 2304fac into develop Dec 20, 2022
@mictro mictro deleted the 2689-bug-tab-routing-is-broken branch December 20, 2022 10:13
@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Tab-routing is broken
2 participants