Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload new icons to kirby #2754

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Upload new icons to kirby #2754

merged 1 commit into from
Jan 12, 2023

Conversation

AgreSanGit
Copy link
Contributor

Which issue does this PR close?

This PR closes #2745

What is the new behavior?

Add new SVGs icons to design system and update cookbook with new icons.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit merged commit 3bb45e1 into develop Jan 12, 2023
@AgreSanGit AgreSanGit deleted the enhancement/2745-upload-icons-to-kirby branch January 12, 2023 16:42
@RasmusKjeldgaard RasmusKjeldgaard added the feature Add this PR to the changelog as a feature label Jan 16, 2023
SigurdVilstrup pushed a commit that referenced this pull request Mar 28, 2023
@AgreSanGit @SigurdVilstrup
Upload new icons to kirby (#2754)
2ec802f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodeaben kodeaben kodeaben approved these changes

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Upload icons to Kirby
3 participants
@AgreSanGit @kodeaben @RasmusKjeldgaard