Remove card mode to align elevation #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
pr-2668-align-card-elevation-2
RasmusKjeldgaard
added
the
breaking-change
github-actions
bot
temporarily deployed
to
pr-2668-align-card-elevation-2
RasmusKjeldgaard
force-pushed
the
enhancement/improve-card-documentation-2
branch
from
177a5aa to
cd01db7
Compare
…ent/2668-align-card-elevation-2
github-actions
bot
temporarily deployed
to
pr-2668-align-card-elevation-2
mark-drastrup
approved these changes
Jan 23, 2023
Base automatically changed from
enhancement/improve-card-documentation-2
to
develop
January 23, 2023 10:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2668
What is the new behavior?
The UX group has requested a change to card elevation. This means that the 'highlighted' mode should no longer be an option, so all cards have equal elevation.
Card should use z-elevation 2 all round, and because z-elevation 4 was only used by card, I have chosen to remove it entirely, and instead make elevation 8 take its place, to not have an arbitrary gap between elevation 2 and 8 when 4 was removed. Components using elevation 8 has been changed to elevation 4 to preserve their existing look.
For this reason it no longer makes sense have a mode input with only one possible value, so I have made the option for making card appear flat as a boolean input instead, and updated the documentation accordingly.
NOTE: This PR: #2808 is a follow-up that properly remaps elevation 8 to elevation 4
Does this PR introduce a breaking change?
The cards 'mode' input is replaced with a boolean input 'flat' that can be set to true to remove the shadow around the card. This should never be used together with a clickable card or a card with a disclosure indicator.
The 'highlighted' look that could previously could be set on cards is no longer an option and all cards will have the same shadow.
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
developby Team Kirby.