-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Alert #2871
Merged
Merged
Experimental Alert #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ign/designsystem into 2855/experimental-alert
kodeaben
reviewed
Feb 20, 2023
...cookbook/src/app/examples/alert-experimental-example/alert-experimental-example.component.ts
Outdated
Show resolved
Hide resolved
...cookbook/src/app/examples/alert-experimental-example/alert-experimental-example.component.ts
Outdated
Show resolved
Hide resolved
...cookbook/src/app/examples/alert-experimental-example/alert-experimental-example.component.ts
Show resolved
Hide resolved
...cookbook/src/app/examples/alert-experimental-example/alert-experimental-example.component.ts
Show resolved
Hide resolved
...cookbook/src/app/examples/alert-experimental-example/alert-experimental-example.component.ts
Show resolved
Hide resolved
libs/designsystem/alert-experimental/src/services/alert.controller.spec.ts
Show resolved
Hide resolved
kodeaben
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #2855
What is the new behavior?
An experimental alert that is meant to replace the current alert in a couple of major releases. This alert is its own secondary entry and doesn't rely on the modal controller, like the current alert. Additionally, it is now possible to subscribe to the
onWillDismiss
andonDidDismiss
events to obtain data back from the alert, instead of providing a callback.Does this PR introduce a breaking change?
Are there any additional context?
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.