Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Alert #2871

Merged
merged 25 commits into from
Feb 23, 2023
Merged

Experimental Alert #2871

merged 25 commits into from
Feb 23, 2023

Conversation

mark-drastrup
Copy link
Contributor

Which issue does this PR close?

This PR closes #2855

What is the new behavior?

An experimental alert that is meant to replace the current alert in a couple of major releases. This alert is its own secondary entry and doesn't rely on the modal controller, like the current alert. Additionally, it is now possible to subscribe to the onWillDismiss and onDidDismiss events to obtain data back from the alert, instead of providing a callback.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mark-drastrup mark-drastrup added the feature Add this PR to the changelog as a feature label Feb 17, 2023
@mark-drastrup mark-drastrup self-assigned this Feb 17, 2023
@github-actions github-actions bot temporarily deployed to pr-experimental-alert February 17, 2023 12:44 Inactive
@mark-drastrup mark-drastrup merged commit fa8b5db into develop Feb 23, 2023
@mark-drastrup mark-drastrup deleted the 2855/experimental-alert branch February 23, 2023 06:18
SigurdVilstrup pushed a commit that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[COMPONENT] New alert component
2 participants