-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting disclosure input to null in kirby-item #2907
Fix setting disclosure input to null in kirby-item #2907
Conversation
Remember to add it to the API table too! |
Should i include a test to verify that the disclosure is removed correctly after setting to null? |
70f4632
to
b95a470
Compare
Good idea, would be a nice addition to ensure that e.g. the fallback icon for kirby-icon is not shown if null is supplied. |
…ally-set-disclosure-on-kriby-item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Which issue does this PR close?
This PR closes #2905
What is the new behavior?
Does this PR introduce a breaking change?
Are there any additional context?
It has been tested to work by modifying the showcase example.
This modification has not been added to the PR as it is a very minor change.
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be merged to
develop
by Team Kirby.