Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting disclosure input to null in kirby-item #2907

Merged

Conversation

bdyhsj
Copy link
Contributor

@bdyhsj bdyhsj commented Feb 28, 2023

Which issue does this PR close?

This PR closes #2905

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

It has been tested to work by modifying the showcase example.
This modification has not been added to the PR as it is a very minor change.

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@bdyhsj bdyhsj added component:Item fix Add this PR to the changelog as a bugfix labels Feb 28, 2023
@github-actions github-actions bot temporarily deployed to pr-2905-conditionally-set-disclosure-on-kriby-item February 28, 2023 15:11 Inactive
@RasmusKjeldgaard
Copy link
Collaborator

Remember to add it to the API table too!

@bdyhsj
Copy link
Contributor Author

bdyhsj commented Mar 1, 2023

Should i include a test to verify that the disclosure is removed correctly after setting to null?

@github-actions github-actions bot temporarily deployed to pr-2905-conditionally-set-disclosure-on-kriby-item March 1, 2023 09:43 Inactive
@bdyhsj bdyhsj force-pushed the bug/2905-conditionally-set-disclosure-on-kriby-item branch from 70f4632 to b95a470 Compare March 1, 2023 13:53
@bdyhsj bdyhsj marked this pull request as ready for review March 1, 2023 13:53
@github-actions github-actions bot temporarily deployed to pr-2905-conditionally-set-disclosure-on-kriby-item March 1, 2023 14:01 Inactive
@RasmusKjeldgaard
Copy link
Collaborator

Should i include a test to verify that the disclosure is removed correctly after setting to null?

Good idea, would be a nice addition to ensure that e.g. the fallback icon for kirby-icon is not shown if null is supplied.

Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@RasmusKjeldgaard RasmusKjeldgaard merged commit 898a146 into develop Mar 7, 2023
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/2905-conditionally-set-disclosure-on-kriby-item branch March 7, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Item fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Conditionally set disclosure on kirby-item
2 participants