Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[KirbyPage] Fix rare title intersection observer bug (#2822)" #2912

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

kodeaben
Copy link
Contributor

@kodeaben kodeaben commented Mar 2, 2023

This reverts commit b1d2d32.

Which issue does this PR close?

This PR closes none, but it fixes an issue described in #2911
It does however also reintroduce the bug it was intended to fix. It is the teams intention to follow up on this with a fix for both issues.

What is the new behavior?

Flicker stops, bug when having circular routing reintroduced

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • [-] Make sure you have implemented tests following the guidelines in: "The good: Test".
  • [-] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • [-] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@kodeaben kodeaben self-assigned this Mar 2, 2023
@kodeaben kodeaben added the fix Add this PR to the changelog as a bugfix label Mar 2, 2023
@kodeaben kodeaben requested a review from jakobe March 2, 2023 14:06
@kodeaben kodeaben enabled auto-merge (squash) March 2, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants