Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2921 progress circle not showing themecolor #2927

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

kodeaben
Copy link
Contributor

@kodeaben kodeaben commented Mar 7, 2023

Which issue does this PR close?

This PR closes #2921

What is the new behavior?

Bug is fixed

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • [-] Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • [-] Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@kodeaben kodeaben added the fix Add this PR to the changelog as a bugfix label Mar 7, 2023
@kodeaben kodeaben self-assigned this Mar 7, 2023
@kodeaben kodeaben requested a review from jakobe March 7, 2023 09:30
@github-actions github-actions bot temporarily deployed to pr-2921-progress-circle-not-showing-themecolor March 7, 2023 09:39 Inactive
@kodeaben kodeaben enabled auto-merge (squash) March 7, 2023 09:56
@kodeaben kodeaben merged commit b70e786 into develop Mar 7, 2023
@kodeaben kodeaben deleted the fix/2921-progress-circle-not-showing-themecolor branch March 7, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Theme colors on ProgressCircle are not shown according to the circles progress
2 participants