Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency for portal directive and mismatch in reference getter/setter types #2967

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

RasmusKjeldgaard
Copy link
Collaborator

Which issue does this PR close?

This PR closes no issue but fixes two compile-time problems that occur when installing Kirby v8.3.0:
image

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@RasmusKjeldgaard RasmusKjeldgaard added the fix Add this PR to the changelog as a bugfix label Mar 29, 2023
@github-actions github-actions bot temporarily deployed to pr-fix-floating-ui-compile-errors March 29, 2023 12:40 Inactive
@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) March 29, 2023 13:21
@RasmusKjeldgaard RasmusKjeldgaard changed the title Fix floating directive and menu compile errors Fix missing dependency for floating directive and mismatch in reference getter/setter types Mar 29, 2023
@RasmusKjeldgaard RasmusKjeldgaard changed the title Fix missing dependency for floating directive and mismatch in reference getter/setter types Fix missing dependency for portal directive and mismatch in reference getter/setter types Mar 29, 2023
@RasmusKjeldgaard RasmusKjeldgaard merged commit bc975a6 into develop Mar 29, 2023
@RasmusKjeldgaard RasmusKjeldgaard deleted the bugfix/fix-floating-ui-compile-errors branch March 29, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Add this PR to the changelog as a bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants