Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons to icon assets #2980

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Add icons to icon assets #2980

merged 1 commit into from
Apr 3, 2023

Conversation

mictro
Copy link
Contributor

@mictro mictro commented Mar 31, 2023 •
edited
Loading

Which issue does this PR close?

This PR closes #2972

What is the new behavior?

Adds 'navigation', 'phone-device' and 'upload' icon.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mictro mictro linked an issue Mar 31, 2023 that may be closed by this pull request
[Enhancement] Add icons to Kirby #2972
Closed
11 tasks
@mictro mictro requested a review from mark-drastrup March 31, 2023 12:15
@mark-drastrup mark-drastrup merged commit cbc2df8 into develop Apr 3, 2023
@mark-drastrup mark-drastrup deleted the enhancement/2972-add-icons-to-kirby branch April 3, 2023 05:20
@mark-drastrup mark-drastrup added the feature Add this PR to the changelog as a feature label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-drastrup mark-drastrup mark-drastrup approved these changes

Assignees
No one assigned
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add icons to Kirby
2 participants
@mictro @mark-drastrup